Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Rm unused opc-ua envars #1083

Merged
merged 4 commits into from
Mar 25, 2020
Merged

NOISSUE - Rm unused opc-ua envars #1083

merged 4 commits into from
Mar 25, 2020

Conversation

manuio
Copy link
Contributor

@manuio manuio commented Mar 25, 2020

Signed-off-by: Manuel Imperiale manuel.imperiale@gmail.com

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
@manuio manuio requested a review from a team as a code owner March 25, 2020 08:18
@codecov-io
Copy link

codecov-io commented Mar 25, 2020

Codecov Report

Merging #1083 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1083      +/-   ##
==========================================
+ Coverage   77.98%   78.01%   +0.02%     
==========================================
  Files          95       95              
  Lines        6672     6672              
==========================================
+ Hits         5203     5205       +2     
+ Misses       1159     1157       -2     
  Partials      310      310              
Impacted Files Coverage Δ
things/service.go 90.44% <0.00%> (+1.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2d70c8...4134b7d. Read the comment docs.

Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manuio manuio merged commit c1df2cb into absmach:master Mar 25, 2020
manuio added a commit that referenced this pull request Oct 12, 2020
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
@manuio manuio deleted the opcua branch February 23, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants