NOISSUE - Implement errors package in bootstrap service #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Apr 1, 2020
Codecov Report
@@ Coverage Diff @@
## master #1093 +/- ##
==========================================
- Coverage 77.38% 77.34% -0.05%
==========================================
Files 95 95
Lines 6872 6723 -149
==========================================
- Hits 5318 5200 -118
+ Misses 1224 1192 -32
- Partials 330 331 +1
Continue to review full report at Codecov.
|
manuio
suggested changes
Apr 1, 2020
manuio
suggested changes
Apr 1, 2020
Signed-off-by: Ivan Milošević <iva@blokovi.com>
Signed-off-by: Ivan Milošević <iva@blokovi.com>
Signed-off-by: Ivan Milošević <iva@blokovi.com>
Signed-off-by: Ivan Milošević <iva@blokovi.com>
manuio
pushed a commit
that referenced
this pull request
Oct 12, 2020
* implement errors in bootstrap service Signed-off-by: Ivan Milošević <iva@blokovi.com> * remove dead code Signed-off-by: Ivan Milošević <iva@blokovi.com> * change errors messages Signed-off-by: Ivan Milošević <iva@blokovi.com> * edit more errors messages Signed-off-by: Ivan Milošević <iva@blokovi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ivan Milošević iva@blokovi.com
What does this do?
Use mainflux errors package in Bootstrap service
Which issue(s) does this PR fix/relate to?
Related to issues #538 and #870
List any changes that modify/break current functionality
API endpoints return error message in response body for errors (not just status response code in header)
Have you included tests for your changes?
Yes