MF-1103 - API key should ignore empty expiration time #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>
Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>
nmarcetic
approved these changes
Apr 7, 2020
mteodor
approved these changes
Apr 7, 2020
Codecov Report
@@ Coverage Diff @@
## master #1104 +/- ##
=======================================
Coverage 77.13% 77.13%
=======================================
Files 95 95
Lines 6769 6771 +2
=======================================
+ Hits 5221 5223 +2
Misses 1211 1211
Partials 337 337
Continue to review full report at Codecov.
|
manuio
pushed a commit
that referenced
this pull request
Oct 12, 2020
* Fix API keys expiration validation Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com> * Fix API docs Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dušan Borovčanin dusan.borovcanin@mainflux.com
What does this do?
This pull request fixes API key expiration validation.
Which issue(s) does this PR fix/relate to?
This pull request fixes #1103.
List any changes that modify/break current functionality
API key validation should allow using tokens with an indefinite duration.
Have you included tests for your changes?
Yes.
Did you document any new/modified functionality?
Yes, API docs are updated.