NOISSUE - Implement errors package in Authentication service #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Milošević <iva@blokovi.com>
Signed-off-by: Ivan Milošević <iva@blokovi.com>
golangcibot
reviewed
Apr 8, 2020
Codecov Report
@@ Coverage Diff @@
## master #1105 +/- ##
==========================================
- Coverage 77.13% 76.95% -0.18%
==========================================
Files 95 95
Lines 6771 6775 +4
==========================================
- Hits 5223 5214 -9
- Misses 1211 1222 +11
- Partials 337 339 +2
Continue to review full report at Codecov.
|
Signed-off-by: Ivan Milošević <iva@blokovi.com>
Signed-off-by: Ivan Milošević <iva@blokovi.com>
dborovcanin
reviewed
Apr 8, 2020
Remove nil case in encode error Signed-off-by: Ivan Milošević <iva@blokovi.com>
dborovcanin
previously approved these changes
Apr 8, 2020
Signed-off-by: Ivan Milošević <iva@blokovi.com>
nmarcetic
approved these changes
Apr 8, 2020
manuio
pushed a commit
that referenced
this pull request
Oct 12, 2020
* Implement errors package in Authn service Signed-off-by: Ivan Milošević <iva@blokovi.com> * remove imported and not used fmt package Signed-off-by: Ivan Milošević <iva@blokovi.com> * wrapped errors when issued new key Signed-off-by: Ivan Milošević <iva@blokovi.com> * remove blank line Signed-off-by: Ivan Milošević <iva@blokovi.com> * Change error message in tests Remove nil case in encode error Signed-off-by: Ivan Milošević <iva@blokovi.com> * return back nil value error handling Signed-off-by: Ivan Milošević <iva@blokovi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ivan Milošević iva@blokovi.com
What does this do?
Use mainflux errors package in Authentication service
Which issue(s) does this PR fix/relate to?
Related to issues #538 and #870
List any changes that modify/break current functionality
API endpoints return error message in response body for errors (not just status response code in header)
Have you included tests for your changes?
Yes