NOISSUE - Implement errors package in senml transformer, readers and writers #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Milošević <iva@blokovi.com>
golangcibot
reviewed
Apr 13, 2020
Codecov Report
@@ Coverage Diff @@
## master #1108 +/- ##
==========================================
- Coverage 76.96% 76.90% -0.06%
==========================================
Files 95 95
Lines 6823 6786 -37
==========================================
- Hits 5251 5219 -32
+ Misses 1231 1224 -7
- Partials 341 343 +2
Continue to review full report at Codecov.
|
Return wrapped error in postgres writer Signed-off-by: Ivan Milošević <iva@blokovi.com>
blokovi
changed the title
manuio
reviewed
Apr 13, 2020
| @@ -31,7 +31,7 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| svcName = "postgres-writer" | |||
| svcName = "postgres-reader" | |||
manuio
suggested changes
Apr 13, 2020
Signed-off-by: Ivan Milošević <iva@blokovi.com>
Signed-off-by: Ivan Milošević <iva@blokovi.com>
nmarcetic
reviewed
Apr 13, 2020
Signed-off-by: Ivan Milošević <iva@blokovi.com>
manuio
pushed a commit
that referenced
this pull request
Oct 12, 2020
…writers (#1108) * Implement errors package in senml transformer, readers and writers Signed-off-by: Ivan Milošević <iva@blokovi.com> * Remove unused const Return wrapped error in postgres writer Signed-off-by: Ivan Milošević <iva@blokovi.com> * fix default db host in postgres writer Signed-off-by: Ivan Milošević <iva@blokovi.com> * fix capital letters in errors messages Signed-off-by: Ivan Milošević <iva@blokovi.com> * use svcName instead of postgres for Promethius initialization Signed-off-by: Ivan Milošević <iva@blokovi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ivan Milošević iva@blokovi.com
What does this do?
Use mainflux errors package in senml transformer, readers and writers
Which issue(s) does this PR fix/relate to?
Related to issues #538 and #870
List any changes that modify/break current functionality
Readers' API endpoints return error message in response body for errors (not just status response code in header)
Have you included tests for your changes?
Yes