NOISSUE - Fix bootstrap token naming and interfaces named args #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
golangcibot
reviewed
Apr 15, 2020
bootstrap/service.go
Outdated
| if err != nil { | ||
| if id == "" { | ||
| // Fail silently. | ||
| bs.sdk.DeleteThing(cfg.MFThing, key) | ||
| bs.sdk.DeleteThing(cfg.MFThing, token) |
There was a problem hiding this comment.
Error return value of bs.sdk.DeleteThing is not checked (from errcheck)
bootstrap/service.go
Outdated
| if err != nil { | ||
| if err == mfsdk.ErrNotFound { | ||
| return mfsdk.Thing{}, errors.Wrap(errThingNotFound, ErrNotFound) | ||
| } | ||
|
|
||
| if id != "" { | ||
| bs.sdk.DeleteThing(thingID, key) | ||
| bs.sdk.DeleteThing(thingID, token) |
There was a problem hiding this comment.
Error return value of bs.sdk.DeleteThing is not checked (from errcheck)
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
dborovcanin
reviewed
Apr 15, 2020
bootstrap/configs.go
Outdated
|
|
||
| // RetrieveByID retrieves the Config having the provided identifier, that is owned | ||
| // by the specified user. | ||
| RetrieveByID(string, string) (Config, error) | ||
| RetrieveByID(key, id string) (Config, error) |
There was a problem hiding this comment.
Consider renaming key to owner in repository methods (both interface and implementation, but in tests also).
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1117 +/- ##
=======================================
Coverage 76.12% 76.12%
=======================================
Files 96 96
Lines 6890 6890
=======================================
Hits 5245 5245
Misses 1295 1295
Partials 350 350 Continue to review full report at Codecov.
|
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
mteodor
approved these changes
Apr 15, 2020
blokovi
approved these changes
Apr 16, 2020
dborovcanin
approved these changes
Apr 16, 2020
| @@ -57,7 +57,7 @@ func NewConfigRepository(db *sqlx.DB, log logger.Logger) bootstrap.ConfigReposit | |||
| return &configRepository{db: db, log: log} | |||
| } | |||
|
|
|||
| func (cr configRepository) Save(cfg bootstrap.Config, connections []string) (string, error) { | |||
| func (cr configRepository) Save(cfg bootstrap.Config, chsConnIDs []string) (string, error) { | |||
There was a problem hiding this comment.
Consider renaming chsConnIDs.
manuio
added a commit
that referenced
this pull request
Oct 12, 2020
* NOISSUE - Fix bootstrap token naming and interfaces named args Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Fix CI bot Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Use owner for repository layer Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Fix reviews Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Manuel Imperiale manuel.imperiale@gmail.com