MF-1088 - Remove message payload content type #1121
Conversation
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
There was a problem hiding this comment.
This looks good, but it will be mandatory that @dusanb94 and @nmarcetic review as well.
Docs will need update, as this breaks the API.
transformers/senml/transformer.go
Outdated
| func New(contentType string) transformers.Transformer { | ||
| return transformer{ | ||
| format: formats[contentType], | ||
| } | ||
| } | ||
|
|
||
| func (n transformer) Transform(msg broker.Message) (interface{}, error) { |
There was a problem hiding this comment.
You can rename func (n transformer) Transform... to func (t transformer) Transform.... Weird receiver name n is a legacy from Normalizer.
transformers/senml/transformer.go
Outdated
| return transformer{ | ||
| format: formats[contentType], | ||
| } |
There was a problem hiding this comment.
It makes sense to have a default format (also, please rename contentType to contentFormat):
format, ok := formats[contentFormat]
if !ok {
format = formats[JSON]
}
return transformer {
format: format,
} Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1121 +/- ##
=======================================
Coverage 75.33% 75.33%
=======================================
Files 101 101
Lines 6853 6853
=======================================
Hits 5163 5163
Misses 1333 1333
Partials 357 357 Continue to review full report at Codecov.
|
* MF-1088 - Remove message payload content type Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Add default contentFormat Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
Signed-off-by: Manuel Imperiale manuel.imperiale@gmail.com
Resolves #1088