MF-1128 - Add golangci-linter to a CI script #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blokovi
changed the title
blokovi
changed the title
Signed-off-by: Ivan Milošević <iva@blokovi.com>
Signed-off-by: Ivan Milošević <iva@blokovi.com>
Signed-off-by: Ivan Milošević <iva@blokovi.com>
Signed-off-by: Ivan Milošević <iva@blokovi.com>
Signed-off-by: Ivan Milošević <iva@blokovi.com>
decrease concurrency to 1 Signed-off-by: Ivan Milošević <iva@blokovi.com>
Signed-off-by: Ivan Milošević <iva@blokovi.com>
Signed-off-by: Ivan Milošević <iva@blokovi.com>
Signed-off-by: Ivan Milošević <iva@blokovi.com>
mteodor
approved these changes
Apr 21, 2020
drasko
requested changes
Apr 21, 2020
manuio
pushed a commit
that referenced
this pull request
Oct 12, 2020
* Add golangci-linter to CI script Signed-off-by: Ivan Milošević <iva@blokovi.com> * add no-config flag Signed-off-by: Ivan Milošević <iva@blokovi.com> * disable staticcheck Signed-off-by: Ivan Milošević <iva@blokovi.com> * disable all except errcheck Signed-off-by: Ivan Milošević <iva@blokovi.com> * add more linters Signed-off-by: Ivan Milošević <iva@blokovi.com> * add verbose flag for debug decrease concurrency to 1 Signed-off-by: Ivan Milošević <iva@blokovi.com> * remove errcheck and verbose flag Signed-off-by: Ivan Milošević <iva@blokovi.com> * enable just golint Signed-off-by: Ivan Milošević <iva@blokovi.com> * fix lint errors Signed-off-by: Ivan Milošević <iva@blokovi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1128