MF-1123 - Move Provision service to monorepo #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dborovcanin
force-pushed
the
provision
branch
2 times, most recently
from
d94d8ed
to
ba602a7
Compare
Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>
Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>
manuio
pushed a commit
that referenced
this pull request
Oct 12, 2020
* Add provision service Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com> * Fix Provision service initial version Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
This pull request adds the Provision service to the core repository.
Which issue(s) does this PR fix/relate to?
This pull request resolves #1123.
List any changes that modify/break current functionality
There are no such changes.
Have you included tests for your changes?
Yes.
Did you document any new/modified functionality?
Yes, but more documentation will be added in #1125.
Notes
Since there is a new version of Mainflux SDK that supports Bootstrap service and more recent versions of Mainflux API, removing SDK wrapper and replacing it with native Mainflux SDK should be done. Test coverage and code refactoring, as well as adding a configuration file will be subject of the following pull requests.