NOISSUE - Remove thing related code from twins service #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>
darkodraskovic
changed the title
dborovcanin
approved these changes
May 7, 2020
manuio
pushed a commit
that referenced
this pull request
Oct 12, 2020
Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formerly, twin service was dependent on Mainflux thing. Every twin was connected to one and only one thing. Now twin is decoupled from thing and is thing agnostic, since its definition relies only on channels and subtopics.
Also, since notifications were published via mqtt, we needed a MF thing in order to publish them. Now they are published directly on NATS, so there is no need to specify thing via env var.
The code related to thing in the upper two senses is now removed.