Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Rename MQTT port variable for docker environment #1170

Merged
merged 1 commit into from
May 12, 2020

Conversation

blokovi
Copy link
Contributor

@blokovi blokovi commented May 12, 2020

Signed-off-by: Ivan Milošević iva@blokovi.com

Align name of variable with mqtt/main.go

…QTT_PORT in docker environment

Signed-off-by: Ivan Milošević <iva@blokovi.com>
@blokovi blokovi requested a review from a team as a code owner May 12, 2020 12:16
Copy link
Collaborator

@nmarcetic nmarcetic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't forget to rename vars in the helm chart also.

@blokovi
Copy link
Contributor Author

blokovi commented May 12, 2020

Please don't forget to rename vars in the helm chart also.

In fact, there was already good var name, in docker is wrong

Copy link
Contributor

@manuio manuio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit 5089fcc into absmach:master May 12, 2020
manuio pushed a commit that referenced this pull request Oct 12, 2020
…QTT_PORT in docker environment (#1170)

Signed-off-by: Ivan Milošević <iva@blokovi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants