MF-995 - Add Twins tests for endpoint list twins and list states #1174

darkodraskovic · 2020-05-13T11:29:59Z

Partially resolves #995

twins/api/http/endpoint_states_test.go

twins/mocks/service.go

twins/api/http/endpoint_states_test.go

manuio

LGTM

codecov-io · 2020-05-15T14:50:57Z

Codecov Report

Merging #1174 into master will increase coverage by 2.55%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1174      +/-   ##
==========================================
+ Coverage   74.71%   77.26%   +2.55%     
==========================================
  Files         102      102              
  Lines        6854     6814      -40     
==========================================
+ Hits         5121     5265     +144     
+ Misses       1378     1181     -197     
- Partials      355      368      +13

Impacted Files	Coverage Δ
twins/service.go	`73.13% <100.00%> (+28.91%)`	⬆️
authn/service.go	`77.50% <0.00%> (-2.88%)`	⬇️
things/service.go	`88.97% <0.00%> (-1.48%)`	⬇️
things/postgres/channels.go	`79.84% <0.00%> (-1.11%)`	⬇️
twins/api/http/responses.go	`85.36% <0.00%> (+29.26%)`	⬆️
twins/api/http/transport.go	`88.27% <0.00%> (+31.48%)`	⬆️
twins/api/http/requests.go	`88.88% <0.00%> (+38.88%)`	⬆️
twins/api/http/endpoint.go	`100.00% <0.00%> (+46.22%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7670e7...bde84fa. Read the comment docs.

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

… and update Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

twins/api/http/endpoint_states_test.go

twins/service_test.go

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

drasko

LGTM

* Add ListTwins test Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com> * Remove monotonic time from twins, definitions and attributes creation and update Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com> * Separate twins and states endpoint tests in two files Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com> * Add state generation helper funcs to state endpoint tests Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com> * Add createStateResponse() to states test Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com> * Add states test cases Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com> * Simplify RetrieveAll twins and states methods Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com> * Add service.go to mocks Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com> * Rename mocks.NewService to mocks.New Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com> * Add error checking to endpoint state tests Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com> * Fix method comment Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com> * Add json response decode success check Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com> * Remove created and updated fields from twin and state res Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com> * Remove definition fields from twin req and res Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com> * Add Create funcs to mocks package Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com> * Add service save state tests Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com> * Add service list states test Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

darkodraskovic requested a review from a team as a code owner May 13, 2020 11:29

manuio suggested changes May 13, 2020

View reviewed changes

twins/api/http/endpoint_states_test.go Outdated Show resolved Hide resolved

twins/api/http/endpoint_states_test.go Outdated Show resolved Hide resolved

manuio suggested changes May 13, 2020

View reviewed changes

twins/api/http/endpoint_states_test.go Outdated Show resolved Hide resolved

manuio suggested changes May 13, 2020

View reviewed changes

twins/api/http/endpoint_states_test.go Outdated Show resolved Hide resolved

manuio suggested changes May 13, 2020

View reviewed changes

twins/api/http/endpoint_states_test.go Outdated Show resolved Hide resolved

darkodraskovic force-pushed the twins_test branch 3 times, most recently from 4918318 to 174d4c1 Compare May 13, 2020 12:56

manuio previously approved these changes May 13, 2020

View reviewed changes

mteodor previously approved these changes May 13, 2020

View reviewed changes

darkodraskovic dismissed stale reviews from mteodor and manuio via 9c2b9eb May 13, 2020 14:14

darkodraskovic force-pushed the twins_test branch 2 times, most recently from 9c2b9eb to f8ad5f8 Compare May 14, 2020 10:05

darkodraskovic marked this pull request as draft May 14, 2020 10:10

darkodraskovic force-pushed the twins_test branch 2 times, most recently from 55532a3 to 91a1c1c Compare May 15, 2020 14:44

darkodraskovic force-pushed the twins_test branch from 91a1c1c to 7d7c5d5 Compare May 15, 2020 16:27

darkodraskovic added 10 commits May 15, 2020 19:34

Add ListTwins test

da33491

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

Remove monotonic time from twins, definitions and attributes creation…

57fd3de

… and update Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

Separate twins and states endpoint tests in two files

e72e336

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

Add state generation helper funcs to state endpoint tests

0deaaa1

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

Add createStateResponse() to states test

5e2668f

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

Add states test cases

bc3ba6c

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

Simplify RetrieveAll twins and states methods

29f3a76

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

Add service.go to mocks

ae07f3d

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

Rename mocks.NewService to mocks.New

1232d3f

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

Add error checking to endpoint state tests

a801337

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

darkodraskovic added 3 commits May 15, 2020 19:34

Fix method comment

668af95

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

Add json response decode success check

1b40ddd

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

Remove created and updated fields from twin and state res

8e2c601

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

darkodraskovic force-pushed the twins_test branch from 9c920c6 to bdabc87 Compare May 15, 2020 17:35

darkodraskovic marked this pull request as ready for review May 15, 2020 17:47

drasko requested changes May 15, 2020

View reviewed changes

twins/api/http/endpoint_states_test.go Outdated Show resolved Hide resolved

darkodraskovic force-pushed the twins_test branch from bdabc87 to 2389017 Compare May 18, 2020 08:21

mteodor reviewed May 18, 2020

View reviewed changes

twins/api/http/endpoint_states_test.go Show resolved Hide resolved

twins/api/http/endpoint_states_test.go Show resolved Hide resolved

dborovcanin reviewed May 18, 2020

View reviewed changes

twins/service_test.go Outdated Show resolved Hide resolved

Remove definition fields from twin req and res

41ca3e4

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

darkodraskovic force-pushed the twins_test branch from 2389017 to 41ca3e4 Compare May 18, 2020 09:56

mteodor previously approved these changes May 18, 2020

View reviewed changes

darkodraskovic marked this pull request as draft May 18, 2020 13:19

Add Create funcs to mocks package

7a0f282

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

darkodraskovic dismissed mteodor’s stale review via 7a0f282 May 18, 2020 13:22

darkodraskovic added 2 commits May 18, 2020 16:35

Add service save state tests

bde84fa

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

Add service list states test

431b537

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

darkodraskovic marked this pull request as ready for review May 18, 2020 16:00

drasko approved these changes May 18, 2020

View reviewed changes

blokovi approved these changes May 18, 2020

View reviewed changes

drasko merged commit b4c8013 into absmach:master May 18, 2020

darkodraskovic deleted the twins_test branch May 21, 2020 07:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MF-995 - Add Twins tests for endpoint list twins and list states #1174

MF-995 - Add Twins tests for endpoint list twins and list states #1174

darkodraskovic commented May 13, 2020

manuio left a comment

codecov-io commented May 15, 2020 •

edited

Loading

drasko left a comment

MF-995 - Add Twins tests for endpoint list twins and list states #1174

MF-995 - Add Twins tests for endpoint list twins and list states #1174

Conversation

darkodraskovic commented May 13, 2020

manuio left a comment

Choose a reason for hiding this comment

codecov-io commented May 15, 2020 • edited Loading

Codecov Report

drasko left a comment

Choose a reason for hiding this comment

codecov-io commented May 15, 2020 •

edited

Loading