Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Update dependencies #1176

Merged
merged 2 commits into from
May 14, 2020
Merged

Conversation

dborovcanin
Copy link
Collaborator

@dborovcanin dborovcanin commented May 14, 2020

Signed-off-by: Dušan Borovčanin dusan.borovcanin@mainflux.com

What does this do?

This pull request updates outdated dependencies.

Which issue(s) does this PR fix/relate to?

There is no such issue.

List any changes that modify/break current functionality

There should be no breaking changes. Dependencies that include breaking changes, such as opcua, are not included in this pull request.

Have you included tests for your changes?

No.

Did you document any new/modified functionality?

No.

Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darkodraskovic darkodraskovic marked this pull request as draft May 14, 2020 10:06
@darkodraskovic darkodraskovic marked this pull request as ready for review May 14, 2020 10:08
manuio
manuio previously approved these changes May 14, 2020
Copy link
Contributor

@manuio manuio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would wait with this one until you revert mProxy keepalive

drasko
drasko previously approved these changes May 14, 2020
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>
@dborovcanin dborovcanin dismissed stale reviews from drasko and manuio via 658f9e9 May 14, 2020 13:34
@dborovcanin dborovcanin changed the title NOISSUE - Update mProxy version NOISSUE - Update dependencies May 14, 2020
manuio
manuio previously approved these changes May 14, 2020
Copy link
Contributor

@manuio manuio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: dusanb <borovcanindusan1@gmail.com.com>
@codecov-io
Copy link

Codecov Report

Merging #1176 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1176      +/-   ##
==========================================
- Coverage   74.71%   74.60%   -0.12%     
==========================================
  Files         102      102              
  Lines        6854     6812      -42     
==========================================
- Hits         5121     5082      -39     
  Misses       1378     1378              
+ Partials      355      352       -3     
Impacted Files Coverage Δ
authn/service.go 77.50% <0.00%> (-2.88%) ⬇️
things/postgres/channels.go 79.84% <0.00%> (-1.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df6f5ad...f40688b. Read the comment docs.

Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit d7670e7 into absmach:master May 14, 2020
manuio pushed a commit that referenced this pull request Oct 12, 2020
* Update dependencies

Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>

* Fix mProxy version

Signed-off-by: dusanb <borovcanindusan1@gmail.com.com>

Co-authored-by: dusanb <borovcanindusan1@gmail.com.com>
@dborovcanin dborovcanin deleted the update-mproxy branch February 17, 2021 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants