MF-1179 - Add a certificate service and certs endpoint to SDK #1188

mteodor · 2020-06-01T13:33:25Z

Signed-off-by: Mirko Teodorovic mirko.teodorovic@gmail.com

Resolves #1179

drasko

This will demand also documentation about new features.

cmd/provision/main.go

pkg/sdk/go/certs.go

provision/config.go

provision/api/requests.go

drasko · 2020-06-05T15:48:02Z

.env

+MF_PROVISION_CERTS_CA=/etc/ssl/certs/ca.crt
+MF_PROVISION_CERTS_CA_KEY=/etc/ssl/certs/ca.key
+MF_PROVISION_CERTS_RSA_BITS=4096
+MF_PROVISION_CERTS_DAYS_VALID=2400h


ENV is called DAYS, but you put hours?

drasko · 2020-06-05T15:49:53Z

pkg/sdk/go/bootstrap.go

@@ -39,7 +39,7 @@ type BootstrapConfig struct {
 	State       int       `json:"state,omitempty"`
 }

-func (sdk mfSDK) AddBootstrap(token string, cfg BootstrapConfig) (string, error) {
+func (sdk *mfSDK) AddBootstrap(token string, cfg BootstrapConfig) (string, error) {


SDK is mutable? Something is probably strange...

drasko · 2020-06-07T13:42:00Z

CI is failing, @mteodor please take a look at this as well.

drasko · 2020-06-10T20:23:40Z

@mteodor what do we do with this PR? Are you closing or moving it to draft for modifications?

drasko · 2020-06-26T17:00:17Z

certs/service.go

+		return "", "", errors.Wrap(ErrFailedCertCreation, ErrRsaBitsValueWrong)
+	}
+	var priv interface{}
+	// p224 := elliptic.P224()


Kill dead code

drasko · 2020-06-26T17:02:35Z

provision/api/endpoint.go

@@ -35,3 +35,24 @@ func doProvision(svc provision.Service) endpoint.Endpoint {

 	}
 }
+
+func doCert(svc provision.Service) endpoint.Endpoint {


What does this function do? Creates Cert? If yes, consider calling it createCert(). Or just Cert().

drasko · 2020-06-26T17:04:37Z

certs/postgres/setup_test.go

+
+	code := m.Run()
+
+	// defers will not be run when using os.Exit


Comments start with capital letter

manuio · 2020-06-30T14:33:29Z

certs/api/metrics.go

+
+func (ms *metricsMiddleware) IssueCert(ctx context.Context, token, thingID string, daysValid string, keyBits int, keyType string) (certs.Cert, error) {
+	defer func(begin time.Time) {
+		ms.counter.With("method", "issue").Add(1)


Use issue_cert here

manuio · 2020-06-30T17:36:35Z

.env

@@ -116,13 +115,44 @@ MF_PROVISION_THINGS_LOCATION=http://things:8182
 MF_PROVISION_USER=
 MF_PROVISION_PASS=
 MF_PROVISION_API_KEY=
-MF_PROVISION_CERTS_SVC_URL=http://localhost/certs
+MF_PROVISION_CERTS_SVC_URL=


Is this used?

Can we let a default value?

manuio · 2020-06-30T17:42:26Z

certs/postgres/certs.go

+
+var (
+	errSaveDB       = errors.New("failed to save certs to database")
+	errRetrieve     = errors.New("failed to retrieve certs  from database")


You have 2 white space in this log. I would maybe use failed to read certs from database

codecov-commenter · 2020-07-01T12:44:48Z

Codecov Report

Merging #1188 into master will decrease coverage by 1.11%.
The diff coverage is 17.88%.

@@            Coverage Diff             @@
##           master    #1188      +/-   ##
==========================================
- Coverage   77.44%   76.32%   -1.12%     
==========================================
  Files         104      106       +2     
  Lines        6875     6909      +34     
==========================================
- Hits         5324     5273      -51     
- Misses       1164     1253      +89     
+ Partials      387      383       -4

Impacted Files	Coverage Δ
certs/postgres/certs.go	`0.00% <0.00%> (ø)`
pkg/sdk/go/certs.go	`0.00% <0.00%> (ø)`
pkg/sdk/go/sdk.go	`96.55% <ø> (ø)`
provision/api/endpoint.go	`0.00% <0.00%> (ø)`
provision/api/logging.go	`0.00% <0.00%> (ø)`
provision/api/transport.go	`0.00% <0.00%> (ø)`
things/api/things/http/transport.go	`90.72% <0.00%> (-1.27%)`	⬇️
things/redis/channels.go	`73.91% <ø> (ø)`
certs/postgres/init.go	`77.41% <77.41%> (ø)`
pkg/sdk/go/message.go	`35.55% <100.00%> (ø)`
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be13613...3670b3c. Read the comment docs.

dborovcanin · 2020-07-01T19:54:22Z

certs/api/endpoint.go

+		if err := req.validate(); err != nil {
+			return nil, err
+		}
+		fmt.Println(fmt.Sprintf("request %v", req))


Please remove debug code.

dborovcanin · 2020-07-01T19:55:15Z

certs/api/endpoint.go

+		}
+
+		return svc.RevokeCert(ctx, req.token, req.ThingID, req.CertSerial)
+


Please remove an empty line.

dborovcanin · 2020-07-01T19:55:58Z

certs/api/logging.go

+
+func (lm *loggingMiddleware) RevokeCert(ctx context.Context, token, thingID, certSerial string) (c certs.Revoke, err error) {
+	defer func(begin time.Time) {
+		message := fmt.Sprintf("Method revoke_certificates for token: %s and thing: %s took %s to complete", token, thingID, time.Since(begin))


"revoke_cert"

dborovcanin · 2020-07-01T19:57:41Z

certs/postgres/certs.go

+	if thingID == "" {
+		return certs.Page{}, errEmptyThingID
+	}


You can move this check to the service layer.

dborovcanin · 2020-07-01T20:00:22Z

certs/postgres/init.go

+						thing_id	TEXT NOT NULL,
+						expire		TIMESTAMPTZ NOT NULL,
+						serial      TEXT NOT NULL,
+						PRIMARY KEY (thing_id, serial)


We can have multiple certificates for one Thing. If there are no practical examples where this can be useful, I would stick with one cert per Thing.

certs/service.go

dborovcanin · 2020-07-01T20:04:16Z

certs/service.go

+	certsRepo Repository
+	sdk       mfsdk.SDK
+	conf      Config
+	PKIClient *api.Client


Can we create a wrapper around this client and use it as a lib? Move custom requests and responses to a separate package and import it in certs service? Also, wrap HTTP requests and responses to make it transparent from the service layer.

@mteodor Can you, please, take a look at this remark?

dborovcanin · 2020-07-01T20:06:15Z

certs/service.go

+	r := cs.PKIClient.NewRequest("POST", cs.getRevokeURL())
+	if err := r.SetJSONBody(cReq); err != nil {
+		return Revoke{}, err
+	}
+
+	resp, err := cs.PKIClient.RawRequest(r)
+	if resp != nil {
+		defer resp.Body.Close()
+	}
+
+	if err != nil {
+		return Revoke{}, err
+	}
+
+	if resp.StatusCode >= http.StatusBadRequest {
+		_, err := ioutil.ReadAll(resp.Body)
+		if err != nil {
+			return Revoke{}, err
+		}
+		return Revoke{}, errors.Wrap(ErrFailedCertCreation, err)
+	}


For example, this code would be in the Vault client wrapper.

manuio · 2020-07-01T22:42:17Z

certs/api/endpoint.go

+	}
+}
+
+func revokeCertificate(svc certs.Service) endpoint.Endpoint {


revokeCert

manuio · 2020-07-01T22:42:32Z

certs/api/endpoint.go

+	}
+}
+
+func listCertificates(svc certs.Service) endpoint.Endpoint {


listCerts

manuio · 2020-07-01T22:42:48Z

certs/api/logging.go

+	return lm.svc.IssueCert(ctx, token, thingID, daysValid, keyBits, keyType)
+}
+
+func (lm *loggingMiddleware) ListCertificates(ctx context.Context, token, thingID string, offset, limit uint64) (cp certs.Page, err error) {


ListCerts

manuio · 2020-07-02T07:21:01Z

certs/postgres/certs.go

+	q := `INSERT INTO certs (thing_id, serial, expire)
+		  VALUES (:thing_id, :serial, :expire)`


IMO No need for 2 lines here

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

dborovcanin · 2020-07-16T11:40:56Z

certs/pki/vault.go

+func (p *pkiAgent) getIssueURL() string {
+	return "/" + apiVer + "/" + p.path + "/" + issue + "/" + p.role
+}
+
+func (p *pkiAgent) getRevokeURL() string {
+	return "/" + apiVer + "/" + p.path + "/" + revoke
+}


Can we use these as fields in pkiAgent? Can we set okiAgent.issueURL and pkiAgent.revokeURL in the NewVaultClient method?

dborovcanin · 2020-07-16T11:41:35Z

certs/pki/vault.go

+// Copyright (c) Mainflux
+// SPDX-License-Identifier: Apache-2.0
+
+// Package postgres contains repository implementations using PostgreSQL as


Wrong package description.

certs/pki/pki.go

certs/api/requests.go

dborovcanin · 2020-07-16T11:45:35Z

certs/postgres/certs_test.go

+)
+
+func TestIssueCert(t *testing.T) {
+


Either delete file or add a test.

certs/swagger.yml

dborovcanin · 2020-07-16T11:47:55Z

docker/addons/certs/docker-compose.yml

+      MF_CERTS_VAULT_ROLE: ${MF_CERTS_VAULT_ROLE}
+    volumes:
+      - ../../ssl/certs/ca.key:/etc/ssl/certs/ca.key
+      - ../../ssl/certs/ca.crt:/etc/ssl/certs/ca.crt


Please add an empty line at the end of the file.

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

manuio

LGTM

* adding certificate issuing Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * adding cert endpoint Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * update envs Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * update envs Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * move certs creation to sdk Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * move certs creation to sdk Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * move certs creation to sdk Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix env vars Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add comment Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * update sdk Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix vars Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add volumes Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix merge config for int Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * remove env Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix error handling Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add cert test, change receiver to pointer Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add docs Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix var naming Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * correct error naming Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * adding certs service Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add certs Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add certs Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * change func receiever Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add default cert issue method Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add config Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * small fix Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * remove some testing code Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add cert issue Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add vault api client Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * additional endpoints Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add swagger for certs Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * remove certs from provision Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * clean provision from certs Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add list certificates endpoint Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add vault api in vendor Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add certs Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add revoke, fix bugs Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix sdk for certs Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * minor changes, add env, doc Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * minor changes, add env, doc Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * minor changes, add env, doc Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * small changes Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * remove CA for signing from provision Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add docker file for certs Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix mock sdk Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add line Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix RevokeCert Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * renam ENV Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * remove tests temporarily Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix naming Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * renam vars Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add cli for issue cert Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add cli for issue cert Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add cli for issue cert Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add cli for issue cert Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * remove not needed envs Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix linter errors, add cli Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix linter errors, add cli, var rename Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix reviews, add viewcert, fix view all certs Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * remove view cert, as it will be retrieved from PKI Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * change endpoints Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add default env val Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * remove some errors Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * refactor, make wrapper lib for vault Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * refactor, make wrapper lib for vault Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * refactor, make wrapper lib for vault Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix revoking Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * refactor, make wrapper lib for vault Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * update vendor Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix comment Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add comments Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * remove unused Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * remove unused field Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * update vendor Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * refactor pki Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * refactor pki Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * refactor pki, update vendor Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * refactor pki Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix comment Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * minor fix Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * remove methods, use fields Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix comments and package desc Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix comments and package desc Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

mteodor added the work-in-progress label Jun 1, 2020

drasko reviewed Jun 3, 2020

View reviewed changes

mteodor force-pushed the add-certs branch 2 times, most recently from 0899715 to dfa6fc3 Compare June 5, 2020 12:35

mteodor marked this pull request as ready for review June 5, 2020 13:40

mteodor requested a review from a team as a code owner June 5, 2020 13:40

manuio reviewed Jun 5, 2020

View reviewed changes

cmd/provision/main.go Show resolved Hide resolved

manuio suggested changes Jun 5, 2020

View reviewed changes

pkg/sdk/go/certs.go Outdated Show resolved Hide resolved

manuio reviewed Jun 5, 2020

View reviewed changes

provision/config.go Outdated Show resolved Hide resolved

manuio suggested changes Jun 5, 2020

View reviewed changes

provision/api/requests.go Outdated Show resolved Hide resolved

mteodor removed the work-in-progress label Jun 5, 2020

mteodor force-pushed the add-certs branch from 47365e4 to 23b167e Compare June 5, 2020 15:49

mteodor self-assigned this Jun 5, 2020

drasko requested changes Jun 5, 2020

View reviewed changes

mteodor added the work-in-progress label Jun 11, 2020

mteodor marked this pull request as draft June 11, 2020 10:57

drasko requested changes Jun 26, 2020

View reviewed changes

manuio suggested changes Jun 30, 2020

View reviewed changes

mteodor force-pushed the add-certs branch from dbb6862 to 811b7c3 Compare June 30, 2020 15:06

mteodor removed the work-in-progress label Jun 30, 2020

mteodor marked this pull request as ready for review June 30, 2020 16:02

manuio reviewed Jun 30, 2020

View reviewed changes

mteodor changed the title ~~MF-1179 - adding certificate endpoint~~ MF-1179 - adding certificate service Jul 1, 2020

dborovcanin changed the title ~~MF-1179 - adding certificate service~~ MF-1179 - Add a certificate service and certs endpoint to SDK Jul 1, 2020

dborovcanin requested changes Jul 1, 2020

View reviewed changes

manuio suggested changes Jul 1, 2020

View reviewed changes

manuio reviewed Jul 2, 2020

View reviewed changes

mteodor added 19 commits July 15, 2020 16:31

change endpoints

f42825e

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

add default env val

6af5156

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

remove some errors

b44ab0b

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

refactor, make wrapper lib for vault

ceb5b1d

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

refactor, make wrapper lib for vault

10ebcb3

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

refactor, make wrapper lib for vault

e896ed9

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

fix revoking

8c4b749

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

refactor, make wrapper lib for vault

586a0ce

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

update vendor

6ad04d0

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

fix comment

6bd9854

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

add comments

1d9da77

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

remove unused

7149443

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

remove unused field

6788cd5

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

update vendor

73176ab

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

refactor pki

599a5f6

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

refactor pki

e296c23

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

refactor pki, update vendor

ffb1ce9

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

refactor pki

c74ba9f

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

fix comment

43c7ac4

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

mteodor force-pushed the add-certs branch from 6d6d0cf to 43c7ac4 Compare July 15, 2020 14:33

dborovcanin requested changes Jul 16, 2020

View reviewed changes

mteodor added 4 commits July 16, 2020 13:53

minor fix

811dc61

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

remove methods, use fields

3670b3c

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

fix comments and package desc

26e1f2d

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

fix comments and package desc

b827f52

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

dborovcanin approved these changes Jul 16, 2020

View reviewed changes

manuio approved these changes Jul 21, 2020

View reviewed changes

manuio merged commit b910244 into absmach:master Jul 21, 2020

mteodor deleted the add-certs branch September 13, 2021 12:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MF-1179 - Add a certificate service and certs endpoint to SDK #1188

MF-1179 - Add a certificate service and certs endpoint to SDK #1188

mteodor commented Jun 1, 2020

drasko left a comment

drasko Jun 5, 2020

drasko Jun 5, 2020

drasko commented Jun 7, 2020

drasko commented Jun 10, 2020

drasko Jun 26, 2020

drasko Jun 26, 2020

drasko Jun 26, 2020

manuio Jun 30, 2020

manuio Jun 30, 2020

mteodor Jul 2, 2020

manuio Jul 2, 2020

manuio Jun 30, 2020

codecov-commenter commented Jul 1, 2020 •

edited

Loading

dborovcanin Jul 1, 2020

dborovcanin Jul 1, 2020

dborovcanin Jul 1, 2020

dborovcanin Jul 1, 2020

dborovcanin Jul 1, 2020

dborovcanin Jul 1, 2020

dborovcanin Jul 13, 2020

dborovcanin Jul 1, 2020

manuio Jul 1, 2020

manuio Jul 1, 2020

manuio Jul 1, 2020

manuio Jul 2, 2020

dborovcanin Jul 16, 2020

dborovcanin Jul 16, 2020 •

edited

Loading

dborovcanin Jul 16, 2020

dborovcanin Jul 16, 2020

manuio left a comment

		}

		return svc.RevokeCert(ctx, req.token, req.ThingID, req.CertSerial)

		q := `INSERT INTO certs (thing_id, serial, expire)
		VALUES (:thing_id, :serial, :expire)`

MF-1179 - Add a certificate service and certs endpoint to SDK #1188

MF-1179 - Add a certificate service and certs endpoint to SDK #1188

Conversation

mteodor commented Jun 1, 2020

drasko left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

drasko commented Jun 7, 2020

drasko commented Jun 10, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-commenter commented Jul 1, 2020 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dborovcanin Jul 16, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

manuio left a comment

Choose a reason for hiding this comment

codecov-commenter commented Jul 1, 2020 •

edited

Loading

dborovcanin Jul 16, 2020 •

edited

Loading