Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NOISSUE - Refactor provision tool #1189

Merged
merged 2 commits into from
Jun 1, 2020
Merged

NOISSUE - Refactor provision tool #1189

merged 2 commits into from
Jun 1, 2020

Conversation

blokovi
Copy link
Contributor

@blokovi blokovi commented Jun 1, 2020

Signed-off-by: Ivan Milošević iva@blokovi.com

What does this do?

  • Use bulk SDK functions for generating Things and Channels for better performance of tool
  • Add prefix option

Did you document any new/modified functionality?

Yes, updated README

@blokovi
Use bulk sdk functions for generating Things and Channels
e72fe64 
Add prefix option

Signed-off-by: Ivan Milošević <iva@blokovi.com>
@blokovi
Update readme
c7cf416 
Remove dead code
Rename variable

Signed-off-by: Ivan Milošević <iva@blokovi.com>
@blokovi blokovi requested a review from a team as a code owner June 1, 2020 14:55
@blokovi blokovi requested a review from mteodor June 1, 2020 14:56
@codecov-commenter
Copy link

Codecov Report

Merging #1189 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1189      +/-   ##
==========================================
+ Coverage   77.29%   77.32%   +0.02%     
==========================================
  Files         102      102              
  Lines        6814     6814              
==========================================
+ Hits         5267     5269       +2     
+ Misses       1180     1178       -2     
  Partials      367      367
Impacted Files Coverage Δ
things/service.go 90.44% <0.00%> (+1.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8906943...c7cf416. Read the comment docs.

mteodor
mteodor approved these changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@mteodor mteodor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

drasko
drasko approved these changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit a5fb55c into absmach:master Jun 1, 2020
@blokovi blokovi deleted the provisionrefactor branch June 1, 2020 15:37
manuio pushed a commit that referenced this pull request Oct 12, 2020
@blokovi
NOISSUE - Refactor provision tool (#1189)
4764b89 
* Use bulk sdk functions for generating Things and Channels
Add prefix option

Signed-off-by: Ivan Milošević <iva@blokovi.com>

* Update readme
Remove dead code
Rename variable

Signed-off-by: Ivan Milošević <iva@blokovi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mteodor mteodor mteodor approved these changes

@drasko drasko drasko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@blokovi @codecov-commenter @drasko @mteodor