Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NOISSUE - Fix typo in error messages #1193

Merged
merged 1 commit into from
Jun 3, 2020
Merged

NOISSUE - Fix typo in error messages #1193

merged 1 commit into from
Jun 3, 2020

Conversation

blokovi
Copy link
Contributor

@blokovi blokovi commented Jun 3, 2020

Signed-off-by: Ivan Milošević iva@blokovi.com

@blokovi blokovi requested a review from a team as a code owner June 3, 2020 07:43
drasko
drasko previously approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dborovcanin
dborovcanin previously approved these changes Jun 3, 2020
View reviewed changes
@blokovi
Fix typo in error messages
c80ab85 
Signed-off-by: Ivan Milošević <iva@blokovi.com>
@blokovi blokovi dismissed stale reviews from dborovcanin and drasko via c80ab85 June 3, 2020 14:38
@codecov-commenter
Copy link

Codecov Report

Merging #1193 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1193   +/-   ##
=======================================
  Coverage   77.24%   77.24%           
=======================================
  Files         102      102           
  Lines        6817     6817           
=======================================
  Hits         5266     5266           
  Misses       1181     1181           
  Partials      370      370
Impacted Files Coverage Δ
pkg/transformers/senml/transformer.go 81.81% <ø> (ø)
readers/cassandra/messages.go 88.46% <ø> (ø)
readers/influxdb/messages.go 76.92% <ø> (ø)
readers/mongodb/messages.go 86.44% <ø> (ø)
readers/postgres/messages.go 90.76% <ø> (ø)
writers/cassandra/messages.go 86.66% <ø> (ø)
writers/influxdb/messages.go 73.33% <ø> (ø)
writers/mongodb/messages.go 73.33% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea3a891...c80ab85. Read the comment docs.

manuio
manuio approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@manuio manuio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

drasko
drasko approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit f1ee9d0 into absmach:master Jun 3, 2020
manuio pushed a commit that referenced this pull request Oct 12, 2020
@blokovi
Fix typo in error messages (#1193)
c8ff3fa 
Signed-off-by: Ivan Milošević <iva@blokovi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drasko drasko drasko approved these changes

@manuio manuio manuio approved these changes

@dborovcanin dborovcanin dborovcanin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@blokovi @codecov-commenter @drasko @manuio @dborovcanin