MF-1198 - Add errors package tests #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>
Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>
Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>
|
Did you consider to include test cases when error is |
manuio
reviewed
Jun 11, 2020
manuio
suggested changes
Jun 11, 2020
|
Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1207 +/- ##
==========================================
- Coverage 77.06% 77.04% -0.03%
==========================================
Files 103 104 +1
Lines 6893 6934 +41
==========================================
+ Hits 5312 5342 +30
- Misses 1197 1206 +9
- Partials 384 386 +2
Continue to review full report at Codecov.
|
Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>
manuio
reviewed
Jun 11, 2020
Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>
darkodraskovic
force-pushed
the
error_tests
branch
from
3917010
to
a5a07d3
Compare
blokovi
approved these changes
Jun 12, 2020
manuio
pushed a commit
that referenced
this pull request
Oct 12, 2020
* Add tests for errors package Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com> * Add recursive fn to gen wrapped errs and func to gen corresponding msg Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com> * Add TestWrap func Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com> * Replace literal string msgs with res of messages() Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com> * Add nil tests for errors.Contains() Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com> * Add nil tests for Wrap() Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit tests to
errorspackage frompkg/.Resolves #1198