NOISSUE - Use pgcrypto instead uuid-ossp for UUIDs generation
#1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1208 +/- ##
=======================================
Coverage 77.04% 77.04%
=======================================
Files 104 104
Lines 6934 6934
=======================================
Hits 5342 5342
Misses 1206 1206
Partials 386 386
Continue to review full report at Codecov.
|
manuio
changed the title
pgcrypto instead uuid-ossp for UUIDs generation pgcrypto instead uuid-ossp for UUIDs generation
|
@sprql This looks good. I didn't understand what's the problem with |
nmarcetic
previously approved these changes
Jun 17, 2020
dborovcanin
requested changes
Jun 18, 2020
users/postgres/init.go
Outdated
| ALTER TABLE IF EXISTS users ADD COLUMN IF NOT EXISTS | ||
| id UUID DEFAULT uuid_generate_v4()`, | ||
| id UUID DEFAULT gen_random_uuid()`, |
There was a problem hiding this comment.
Before I approve, can you just set id column to NOT NULL (id UUID NOT NULL DEFAULT uuid_generate_v4()), as well? We didn't include this change to any release, so it's safe to change this migration instead of adding another one.
…rsion 4) According to https://www.postgresql.org/docs/current/uuid-ossp.html it's recommended to use https://www.postgresql.org/docs/current/pgcrypto.html for randomly-generated (version 4) UUIDs Signed-off-by: Alexander Obukhov <dev@sprql.space>
dborovcanin
approved these changes
Jun 18, 2020
manuio
pushed a commit
that referenced
this pull request
Oct 12, 2020
…rsion 4) (#1208) According to https://www.postgresql.org/docs/current/uuid-ossp.html it's recommended to use https://www.postgresql.org/docs/current/pgcrypto.html for randomly-generated (version 4) UUIDs Signed-off-by: Alexander Obukhov <dev@sprql.space>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to
https://www.postgresql.org/docs/current/uuid-ossp.html