Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MF-1199 - Add NATS messaging tests #1209

Merged
merged 8 commits into from
Jul 14, 2020
Merged

MF-1199 - Add NATS messaging tests #1209

merged 8 commits into from
Jul 14, 2020

Conversation

darkodraskovic
Copy link
Contributor

@darkodraskovic darkodraskovic commented Jun 17, 2020 •
edited
Loading

Partially resolves #1199

@darkodraskovic darkodraskovic requested a review from a team as a code owner June 17, 2020 11:34
@darkodraskovic darkodraskovic marked this pull request as draft June 17, 2020 11:34
drasko
drasko previously approved these changes Jun 17, 2020
View reviewed changes
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test looks nice and shows how elegant are the abstractions (Publisher and Subscriber interfaces) that we introduced.

Approved from my side, but @dusanb94 needs to review.

@drasko drasko requested a review from dborovcanin June 17, 2020 23:55
@dborovcanin
Copy link
Collaborator

This test looks nice and shows how elegant are the abstractions (Publisher and Subscriber interfaces) that we introduced.

Approved from my side, but @dusanb94 needs to review.

Let's wait for tests to be finished and CI to pass.

@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2020 •
edited
Loading

Codecov Report

Merging #1209 into master will decrease coverage by 0.47%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1209      +/-   ##
==========================================
- Coverage   77.44%   76.96%   -0.48%     
==========================================
  Files         104      106       +2     
  Lines        6875     6955      +80     
==========================================
+ Hits         5324     5353      +29     
- Misses       1164     1205      +41     
- Partials      387      397      +10
Impacted Files Coverage Δ
pkg/messaging/nats/publisher.go 26.31% <0.00%> (ø)
pkg/messaging/nats/pubsub.go 39.34% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2453cd7...b5c37a5. Read the comment docs.

@drasko drasko added this to the 0.12.0 milestone Jun 25, 2020
@drasko drasko removed this from the 0.12.0 milestone Jun 25, 2020
@darkodraskovic darkodraskovic marked this pull request as ready for review July 9, 2020 15:08
drasko
drasko previously approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mteodor
mteodor previously approved these changes Jul 10, 2020
View reviewed changes
manuio
manuio suggested changes Jul 10, 2020
View reviewed changes
pkg/messaging/mqtt/setup_test.go Outdated Show resolved Hide resolved
manuio
manuio suggested changes Jul 10, 2020
View reviewed changes
pkg/messaging/mqtt/setup_test.go Outdated Show resolved Hide resolved
pkg/messaging/mqtt/setup_test.go Outdated Show resolved Hide resolved
pkg/messaging/mqtt/setup_test.go Outdated Show resolved Hide resolved
pkg/messaging/mqtt/setup_test.go Outdated Show resolved Hide resolved
pkg/messaging/mqtt/setup_test.go Outdated Show resolved Hide resolved
pkg/messaging/nats/setup_test.go Outdated Show resolved Hide resolved
pkg/messaging/nats/setup_test.go Outdated Show resolved Hide resolved
pkg/messaging/nats/setup_test.go Show resolved Hide resolved
pkg/messaging/nats/setup_test.go Show resolved Hide resolved
pkg/messaging/nats/setup_test.go Show resolved Hide resolved
@darkodraskovic darkodraskovic dismissed stale reviews from mteodor and drasko via fb7d6dc July 13, 2020 13:16
@darkodraskovic darkodraskovic force-pushed the messages_tests branch 2 times, most recently from fb7d6dc to 6f0d8e1 Compare July 13, 2020 14:03
@darkodraskovic
Add test setup for mqtt
19d8129 
Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>
@darkodraskovic
Add pubsub tests
205dc17 
Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>
@darkodraskovic
Add message and payload helper funcs
cffd7f9 
Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>
@darkodraskovic
Add time.Sleep after subscribe to topic
defba71 
Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>
@darkodraskovic
Add NATS tests setup
d4684f7 
Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>
@darkodraskovic
Add NATS test cases
3bd9a1f 
Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>
@darkodraskovic
Add message forwarded check to handler
3442afd 
Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>
@darkodraskovic
Remove race affected mqtt tests
b5c37a5 
Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>
@darkodraskovic darkodraskovic changed the title MF-1197 - Add MQTT adapter tests MF-1197 - Add NATS adapter tests Jul 14, 2020
@darkodraskovic darkodraskovic changed the title MF-1197 - Add NATS adapter tests MF-1197 - Add NATS messaging tests Jul 14, 2020
@darkodraskovic darkodraskovic changed the title MF-1197 - Add NATS messaging tests MF-1199 - Add NATS messaging tests Jul 14, 2020
drasko
drasko approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

manuio
manuio approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@manuio manuio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manuio manuio merged commit c1088b9 into absmach:master Jul 14, 2020
@darkodraskovic darkodraskovic deleted the messages_tests branch August 10, 2020 10:46
manuio pushed a commit that referenced this pull request Oct 12, 2020
@darkodraskovic
MF-1199 - Add NATS messaging tests (#1209)
696ce82 
* Add test setup for mqtt

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

* Add pubsub tests

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

* Add message and payload helper funcs

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

* Add time.Sleep after subscribe to topic

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

* Add NATS tests setup

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

* Add NATS test cases

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

* Add message forwarded check to handler

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

* Remove race affected mqtt tests

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drasko drasko drasko approved these changes

@manuio manuio manuio approved these changes

@dborovcanin dborovcanin dborovcanin approved these changes

@mteodor mteodor mteodor left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add messaging tests
6 participants
@darkodraskovic @dborovcanin @codecov-commenter @drasko @mteodor @manuio