Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE: fix envs for nginx #1215

Merged
merged 1 commit into from
Jul 8, 2020
Merged

Conversation

mteodor
Copy link
Contributor

@mteodor mteodor commented Jul 7, 2020

Signed-off-by: Mirko Teodorovic mirko.teodorovic@gmail.com

What does this do?

This fixes setting ports for nginx with .env file

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
@mteodor mteodor requested a review from a team as a code owner July 7, 2020 20:01
@codecov-commenter
Copy link

Codecov Report

Merging #1215 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1215      +/-   ##
==========================================
+ Coverage   76.99%   77.02%   +0.02%     
==========================================
  Files         104      104              
  Lines        6868     6868              
==========================================
+ Hits         5288     5290       +2     
+ Misses       1198     1196       -2     
  Partials      382      382              
Impacted Files Coverage Δ
things/service.go 86.33% <0.00%> (+1.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7eee53...9780e5d. Read the comment docs.

Copy link
Contributor

@manuio manuio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manuio manuio merged commit 09d09c6 into absmach:master Jul 8, 2020
manuio pushed a commit that referenced this pull request Oct 12, 2020
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
@mteodor mteodor deleted the fix-nginx-envs branch September 13, 2021 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants