NOISUE - Fix cache error when key is not in Redis #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dborovcanin
force-pushed
the
fix-auth-cache
branch
2 times, most recently
from
6d13a34
to
f101bf3
Compare
manuio
reviewed
Jul 14, 2020
things/redis/things.go
Outdated
| var ErrRedisThingSave = errors.New("saving thing in redis cache error") | ||
| var ( | ||
| // ErrRedisThingSave indicates error while saving Thing in redis cache | ||
| ErrRedisThingSave = errors.New("saving thing in redis cache error") |
There was a problem hiding this comment.
failed to save thing in redis cache
manuio
reviewed
Jul 14, 2020
things/redis/things.go
Outdated
| // ErrRedisThingID indicates error while geting Thing ID from redis cache | ||
| var ErrRedisThingID = errors.New("get thing id from redis cache error") | ||
| // ErrRedisThingID indicates error while geting Thing ID from redis cache | ||
| ErrRedisThingID = errors.New("get thing id from redis cache error") |
There was a problem hiding this comment.
failed to get thing id from redis cache
manuio
reviewed
Jul 14, 2020
things/redis/things.go
Outdated
| // ErrRedisThingRemove indicates error while removing Thing from redis cache | ||
| var ErrRedisThingRemove = errors.New("remove thing from redis cache error") | ||
| // ErrRedisThingRemove indicates error while removing Thing from redis cache | ||
| ErrRedisThingRemove = errors.New("remove thing from redis cache error") |
There was a problem hiding this comment.
failed to remove thing from redis cache
Codecov Report
@@ Coverage Diff @@
## master #1220 +/- ##
==========================================
- Coverage 77.44% 76.87% -0.57%
==========================================
Files 104 106 +2
Lines 6875 6961 +86
==========================================
+ Hits 5324 5351 +27
- Misses 1164 1212 +48
- Partials 387 398 +11
Continue to review full report at Codecov.
|
dborovcanin
force-pushed
the
fix-auth-cache
branch
from
3089280
to
1dd8880
Compare
Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>
Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>
manuio
pushed a commit
that referenced
this pull request
Oct 12, 2020
* Fix cache error when key is not in Redis Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> * Fix tests Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> * Fix errors message Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dusanb94 dusan.borovcanin@mainflux.com
What does this do?
This pull request fixes an error Things service throws in case that key is not present in Redis. In that case, Redis returns an error, which is actually nil but is not nil type.
Which issue(s) does this PR fix/relate to?
There is no such issue.
List any changes that modify/break current functionality
There are no changes that modify current functionality.
Have you included tests for your changes?
No.
Did you document any new/modified functionality?
No.