NOISSUE - Fix typo in authorization.js #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Milošević <iva@blokovi.com>
mteodor
reviewed
Jul 28, 2020
| @@ -5,7 +5,7 @@ function authenticate(s) { | |||
| if (!s.variables.ssl_client_s_dn || !s.variables.ssl_client_s_dn.length || | |||
| !s.variables.ssl_client_verify || s.variables.ssl_client_verify != "SUCCESS") { | |||
| s.deny(); | |||
| return | |||
| return; | |||
There was a problem hiding this comment.
can you do the same in UI repo
There was a problem hiding this comment.
Sure. I'll change it in devops also, that's where I spot it
There was a problem hiding this comment.
Here it is
I couldn't even start nginx without this fix in kubernetes because of this syntax error, but obviously in other environments this is not an issue.
mteodor
approved these changes
Jul 28, 2020
dborovcanin
approved these changes
Jul 28, 2020
Codecov Report
@@ Coverage Diff @@
## master #1226 +/- ##
=======================================
Coverage 76.39% 76.39%
=======================================
Files 106 106
Lines 6964 6964
=======================================
Hits 5320 5320
Misses 1259 1259
Partials 385 385 Continue to review full report at Codecov.
|
manuio
pushed a commit
that referenced
this pull request
Oct 12, 2020
Signed-off-by: Ivan Milošević <iva@blokovi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ivan Milošević iva@blokovi.com
Pull request title should be
MF-XXX - descriptionorNOISSUE - descriptionwhere XXX is ID of issue that this PR relate to.Please review the CONTRIBUTING.md file for detailed contributing guidelines.
What does this do?
Add missing semicolon in
authorization.js