some mainflux-docker.sh and docker-compose cleanup #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drasko
requested changes
Oct 19, 2017
| - $PWD/docker/nginx.conf:/etc/nginx/nginx.conf | ||
| - $PWD/docker/ssl/certs/mainflux-server.crt:/etc/ssl/certs/mainflux-server.crt | ||
| - $PWD/docker/ssl/certs/mainflux-server.key:/etc/ssl/private/mainflux-server.key | ||
| - $PWD/docker/ssl/dhparam.pem:/etc/ssl/certs/dhparam.pem |
There was a problem hiding this comment.
@Essarelle looks like you are not launching the script from the correct dir, as noted here: https://github.com/mainflux/mainflux#docker
You should cd mainflux/bin and launch from there (i.e. from the same dir where mainflux-docker.sh lives).
|
All commits must be signed-off, as explained here: https://github.com/mainflux/mainflux/blob/master/CONTRIBUTING.md#pull-requests, point 4. Also, please squash commit history not to have 3 different commits for one simple change. |
|
Closing because of inactivity. |
mteodor
pushed a commit
to mteodor/mainflux
that referenced
this pull request
Jun 9, 2021
* NOISSUE - Add Users page Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Use /users/profile endpoint Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
SammyOina
added a commit
to SammyOina/mainflux
that referenced
this pull request
Oct 22, 2023
The proxy address was not being set correctly in the main.go file, resulting in incorrect routing of HTTP requests. This commit fixes the bug by correctly setting the proxy address. Additionally, it registers the proxy handler for all incoming requests. Fixes: absmach#123 Signed-off-by: SammyOina <sammyoina@gmail.com>
drasko
pushed a commit
that referenced
this pull request
Oct 23, 2023
* update http messaging to mproxy Signed-off-by: SammyOina <sammyoina@gmail.com> * Fix import path for mproxy module The import path for the mproxy module has been updated to github.com/sammyoina/mproxy v0.0.0-20231005134356-c44220b46ea0. This change ensures that the correct version of the module is used. This commit fixes the import path for the mproxy module, updating it to github.com/sammyoina/mproxy v0.0.0-20231005134356-c44220b46ea0. Signed-off-by: SammyOina <sammyoina@gmail.com> * Fix inconsistent variable naming in streams_test.go The variable "defaultTimout" was misspelled and should be "defaultTimeout". Also, the unused variable "configList" was removed. - Fix variable name "defaultTimout" to "defaultTimeout" - Remove unused variable "configList" Signed-off-by: SammyOina <sammyoina@gmail.com> * update mproxy Signed-off-by: SammyOina <sammyoina@gmail.com> * update mproxy Signed-off-by: SammyOina <sammyoina@gmail.com> * use auth connect Signed-off-by: SammyOina <sammyoina@gmail.com> * Fix incorrect HTTP status code in endpoint_test.go The previous commit introduced a mistake in the HTTP status code used in the endpoint_test.go file. The status code http.StatusUnauthorized was changed to http.StatusBadGateway. This commit corrects the status code to http.StatusBadRequest. This commit also includes a minor change in the things.go file. It adds three lines of code to the Authorize function. These changes ensure that the test cases and authorization logic are aligned with the correct HTTP status codes. Signed-off-by: SammyOina <sammyoina@gmail.com> * fix errors Signed-off-by: SammyOina <sammyoina@gmail.com> * Fix import formatting in message_test.go The import statements in message_test.go were not properly formatted. This commit fixes the formatting by organizing the imports and removing unnecessary commented code. - Import statements were organized and grouped together. - Unnecessary commented code was removed. This commit resolves the import formatting issue in message_test.go, ensuring that the codebase adheres to proper formatting conventions. Signed-off-by: SammyOina <sammyoina@gmail.com> * Fix import order and add missing import in endpoint_test.go The import order in the `endpoint_test.go` file has been fixed, and the missing import for `mainflux/mainflux` has been added. Signed-off-by: SammyOina <sammyoina@gmail.com> * Fix targetHTTPHost value in main.go and remove commented code in endpoint_test.go Summary: Fix targetHTTPHost value and remove commented code Body: - In main.go, fix the value of targetHTTPHost to "http://localhost" - In endpoint_test.go, remove commented code This commit fixes the targetHTTPHost value in main.go and removes unnecessary commented code in endpoint_test.go. The targetHTTPHost value was previously empty and has been updated to "http://localhost" to correctly specify the target HTTP host. Additionally, the commented code in endpoint_test.go has been removed for cleaner code. Signed-off-by: SammyOina <sammyoina@gmail.com> * Fix typo in log statement Signed-off-by: SammyOina <sammyoina@gmail.com> * Refactor HTTP server startup logic Refactor the logic for starting the HTTP server in the `main.go` file. Instead of directly starting the server and logging the server details, the code now uses a goroutine to start the server. This change improves code readability and maintainability. The commit message follows the best practices for writing commit messages. It starts with a succinct one-line summary of the changes, which is no longer than 50 characters. The summary is capitalized and written in the imperative mood. The summary is followed by a more detailed description, separated by a blank line. The body of the message provides context and reasoning behind the changes. Signed-off-by: SammyOina <sammyoina@gmail.com> * Fix import and variable assignment in main.go The import "github.com/mainflux/mainflux/pkg/messaging" was removed and the variable assignment for "h" in main() was updated to remove the unnecessary slice brackets. This commit fixes the import and variable assignment in main.go to ensure proper functionality. Signed-off-by: SammyOina <sammyoina@gmail.com> * Fix typo in function name The function name "newProxyHTPPServer" was misspelled and has been corrected to "newProxyHTTPServer". This commit fixes the typo in the function name. Signed-off-by: SammyOina <sammyoina@gmail.com> * Fix Docker clean command in Makefile The Docker clean command in the Makefile has been fixed to include the Docker profile and project name. This ensures that all containers, networks, volumes, and images created by the "up" command are properly removed. Signed-off-by: SammyOina <sammyoina@gmail.com> * Fix proxy address bug in main.go The proxy address was not being set correctly in the main.go file, resulting in incorrect routing of HTTP requests. This commit fixes the bug by correctly setting the proxy address. Additionally, it registers the proxy handler for all incoming requests. Fixes: #123 Signed-off-by: SammyOina <sammyoina@gmail.com> * Refactor main.go to simplify HTTP server setup The previous implementation of the main.go file had unnecessary complexity in setting up the HTTP server. This commit simplifies the code by removing the unnecessary switch statement and consolidating the server setup logic. The main changes include: - Removing the switch statement that handled HTTPS server setup - Consolidating the server setup logic into a single goroutine - Removing the unnecessary goroutine for starting the server These changes make the code more readable and maintainable by reducing unnecessary complexity and improving the overall structure of the code. Signed-off-by: SammyOina <sammyoina@gmail.com> --------- Signed-off-by: SammyOina <sammyoina@gmail.com>
arvindh123
pushed a commit
to arvindh123/magistrala
that referenced
this pull request
Dec 17, 2023
* Fix pkg tests Signed-off-by: felix.gateru <felix.gateru@gmail.com> * fix errors * refactor groups tests Signed-off-by: felix.gateru <felix.gateru@gmail.com> * Add opts to docker containers Signed-off-by: felix.gateru <felix.gateru@gmail.com> * Fix pkg tests Signed-off-by: felix.gateru <felix.gateru@gmail.com> * Remove unvailable publish test Signed-off-by: felix.gateru <felix.gateru@gmail.com> * Remove unvailable publish test Signed-off-by: felix.gateru <felix.gateru@gmail.com> * Cleaning up Signed-off-by: felix.gateru <felix.gateru@gmail.com> * Cleaning up Signed-off-by: felix.gateru <felix.gateru@gmail.com> --------- Signed-off-by: felix.gateru <felix.gateru@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.