NOISSUE - Add new endpoint to retrieve configuration to be used as a template. #1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
mteodor
force-pushed
the
provision-get
branch
from
eb4fe91
to
8e1fb90
Compare
manuio
suggested changes
Sep 25, 2020
provision/service.go
Outdated
| return "", errors.Wrap(ErrUnauthorized, err) | ||
| } | ||
| return ps.conf.Bootstrap.Content, nil | ||
|
|
provision/api/logging.go
Outdated
| defer func(begin time.Time) { | ||
| message := fmt.Sprintf("Method mapping for token: %s took %s to complete", token, time.Since(begin)) | ||
| if err != nil { | ||
| lm.logger.Warn(fmt.Sprintf("%s with error: %s.", message, err)) |
provision/api/logging.go
Outdated
| lm.logger.Warn(fmt.Sprintf("%s with error: %s.", message, err)) | ||
| return | ||
| } | ||
| lm.logger.Info(fmt.Sprintf("%s without errors.", message)) |
provision/swagger.yml
Outdated
Comment on lines
77
to
78
|
|
||
|
|
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1242 +/- ##
==========================================
- Coverage 68.03% 67.82% -0.21%
==========================================
Files 108 108
Lines 7136 7161 +25
==========================================
+ Hits 4855 4857 +2
- Misses 1850 1873 +23
Partials 431 431
Continue to review full report at Codecov.
|
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
dborovcanin
reviewed
Sep 28, 2020
provision/service.go
Outdated
| @@ -81,6 +84,14 @@ func New(cfg Config, sdk SDK.SDK, logger logger.Logger) Service { | |||
| } | |||
| } | |||
|
|
|||
| // Mapping retrieves current configuration | |||
| func (ps *provisionService) Mapping(token string) (interface{}, error) { | |||
There was a problem hiding this comment.
Maybe we can at least return map[string]interface instead of interface{}. It's of little use, but better than interface{}.
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
manuio
approved these changes
Sep 28, 2020
dborovcanin
approved these changes
Sep 29, 2020
manuio
pushed a commit
that referenced
this pull request
Oct 12, 2020
…template. (#1242) * add provision service Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix code style Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix test for provision Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * extra line Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * return map[string]interface instead of interface Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Adds new endpoint that will retrieve current provision template configuration as JSON.
It can be used in UI to populate configuration in a same way as
provisionservice does