NOISSUE - Fix ViewGroup and UpdateGroup #1269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
mteodor
reviewed
Oct 26, 2020
| @@ -129,6 +129,7 @@ func (req createGroupReq) validate() error { | |||
|
|
|||
| type updateGroupReq struct { | |||
| token string | |||
| id string | |||
| Name string `json:"name,omitempty"` | |||
| Description string `json:"description,omitempty"` | |||
There was a problem hiding this comment.
we need parent id here also
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
dborovcanin
reviewed
Oct 26, 2020
users/api/requests.go
Outdated
Comment on lines
143
to
151
| if req.id == "" { | ||
| return users.ErrMalformedEntity | ||
| } | ||
| if req.Name == "" { | ||
| return users.ErrMalformedEntity | ||
| } | ||
| if len(req.Name) > maxNameSize { | ||
| return users.ErrMalformedEntity | ||
| } |
There was a problem hiding this comment.
You can or these conditions.
There was a problem hiding this comment.
I meant that you can or all of these checks: if id == "" || name == "" || len(name) > maxNameLen.
There was a problem hiding this comment.
I agreed to group this checks by type but for consistency with other services and readability I would keep it like that.
You can check here: https://github.com/mainflux/mainflux/blob/master/things/api/things/http/requests.go
mteodor
reviewed
Oct 26, 2020
| } | ||
|
|
||
| group := users.Group{ | ||
| Name: req.Name, |
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
mteodor
previously approved these changes
Oct 26, 2020
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
drasko
reviewed
Oct 26, 2020
dborovcanin
approved these changes
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Manuel Imperiale manuel.imperiale@gmail.com