Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Remove authz from docker comp #1307

Merged
merged 3 commits into from
Dec 16, 2020

Conversation

mteodor
Copy link
Contributor

@mteodor mteodor commented Dec 16, 2020

What does this do?

Remove authz service from docker composition as authz functionality will be merged with authn service

@mteodor mteodor requested a review from a team as a code owner December 16, 2020 15:24
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
@mteodor mteodor force-pushed the remove-authz-from-docker-comp branch from 300431e to c9e3c51 Compare December 16, 2020 15:25
Comment on lines 99 to 105
{
Id: "users_5",
Up: []string{
`ALTER TABLE IF EXISTS users DROP CONSTRAINT IF EXISTS users_owner_id_fkey`,
`ALTER TABLE IF EXISTS users DROP COLUMN IF EXISTS owner_id`,
},
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead migration?

Copy link
Contributor

@manuio manuio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@nmarcetic nmarcetic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mteodor You still have 3 commits. Is there is a special reason why you are removing docker-compose stuff before authz is merged in authn? Does this will break functionality?

@nmarcetic nmarcetic closed this Dec 16, 2020
@mteodor
Copy link
Contributor Author

mteodor commented Dec 16, 2020

@mteodor You still have 3 commits. Is there is a special reason why you are removing docker-compose stuff before authz is merged in authn? Does this will break functionality?

authz is not used, and there is a problem with starting the service in docker composition so that is why I removed it
authz was not complete since it was the idea to break it in few PR's
in a meanwhile we decided to have authn and authz in one service

@nmarcetic
Copy link
Collaborator

@mteodor I see. Thanks for the clarification.
Maybe is a good idea to remove it from all builds like Makefile (build, push etc...) and leave just source code for now.

@nmarcetic nmarcetic reopened this Dec 16, 2020
@nmarcetic nmarcetic merged commit 8aadc0f into absmach:master Dec 16, 2020
@mteodor mteodor deleted the remove-authz-from-docker-comp branch September 13, 2021 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants