-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NOISSUE - Remove authz from docker comp #1307
NOISSUE - Remove authz from docker comp #1307
Conversation
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
300431e
to
c9e3c51
Compare
users/postgres/init.go
Outdated
{ | ||
Id: "users_5", | ||
Up: []string{ | ||
`ALTER TABLE IF EXISTS users DROP CONSTRAINT IF EXISTS users_owner_id_fkey`, | ||
`ALTER TABLE IF EXISTS users DROP COLUMN IF EXISTS owner_id`, | ||
}, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dead migration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mteodor You still have 3 commits. Is there is a special reason why you are removing docker-compose stuff before authz
is merged in authn
? Does this will break functionality?
authz is not used, and there is a problem with starting the service in docker composition so that is why I removed it |
@mteodor I see. Thanks for the clarification. |
What does this do?
Remove
authz
service from docker composition asauthz
functionality will be merged withauthn
service