Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Auth typo #1319

Merged
merged 1 commit into from
Jan 11, 2021
Merged

NOISSUE - Auth typo #1319

merged 1 commit into from
Jan 11, 2021

Conversation

manuio
Copy link
Contributor

@manuio manuio commented Jan 10, 2021

Signed-off-by: Manuel Imperiale manuel.imperiale@gmail.com

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
@manuio manuio requested a review from a team as a code owner January 10, 2021 13:54
@codecov-io
Copy link

Codecov Report

Merging #1319 (75e396c) into master (3eca692) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1319      +/-   ##
==========================================
+ Coverage   59.79%   59.81%   +0.02%     
==========================================
  Files         113      113              
  Lines        8797     8797              
==========================================
+ Hits         5260     5262       +2     
+ Misses       3080     3078       -2     
  Partials      457      457              
Impacted Files Coverage Δ
auth/api/grpc/server.go 56.62% <ø> (ø)
auth/service.go 43.96% <ø> (ø)
things/service.go 54.54% <0.00%> (+1.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3eca692...75e396c. Read the comment docs.

Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dborovcanin dborovcanin merged commit ac09815 into absmach:master Jan 11, 2021
fbugarski pushed a commit to fbugarski/mainflux that referenced this pull request Mar 8, 2021
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
@manuio manuio deleted the auth-typo branch February 23, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants