NOISSUE - Fix run script and compiler warnings #1336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1336 +/- ##
==========================================
- Coverage 59.92% 59.91% -0.01%
==========================================
Files 113 113
Lines 8860 8858 -2
==========================================
- Hits 5309 5307 -2
- Misses 3085 3086 +1
+ Partials 466 465 -1
Continue to review full report at Codecov.
|
drasko
requested changes
Jan 23, 2021
dborovcanin
force-pushed
the
fix-run
branch
2 times, most recently
from
4ed47ff
to
2d24a3a
Compare
Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>
Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>
nmarcetic
reviewed
Jan 25, 2021
| @@ -82,9 +82,6 @@ func (repo mongoRepository) ReadAll(chanID string, offset, limit uint64, query m | |||
| if err != nil { | |||
| return readers.MessagesPage{}, errors.Wrap(errReadMessages, err) | |||
| } | |||
| if total < 0 { | |||
There was a problem hiding this comment.
It's not addressed in PR, not sure if it's accidentally removed?
There was a problem hiding this comment.
It's removed because total is uint type, so this can never be true (in fact, that's why we use uint instead of int).
nmarcetic
approved these changes
Jan 25, 2021
fbugarski
pushed a commit
to fbugarski/mainflux
that referenced
this pull request
Mar 8, 2021
* Fix NATS server naming in run script Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> * Fix warnings Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> * Fix typo Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dusanb94 dusan.borovcanin@mainflux.com
What does this do
This pull request addresses:
int64tostringin Twins service.Which issue(s) does this PR fix/relate to?
There is no such issue.
List any changes that modify/break current functionality
There are no breaking changes.
Have you included tests for your changes?
No, because no new features are added.
Did you document any new/modified functionality?
No, there is no cush functionality.