-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NOISSUE - Upgrade influxdb and postgres docker images #1341
Conversation
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1341 +/- ##
=======================================
Coverage 60.02% 60.02%
=======================================
Files 113 113
Lines 8904 8904
=======================================
Hits 5345 5345
Misses 3090 3090
Partials 469 469 Continue to review full report at Codecov.
|
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
@@ -17,7 +17,7 @@ volumes: | |||
|
|||
services: | |||
bootstrap-db: | |||
image: postgres:10.2-alpine | |||
image: postgres:10.8-alpine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is version 13 available, should with a try with the latest or there is a specific reason to use 10.x?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because version 13 doesn't support DBs initialised with version 10. We can probably do it for the next release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really? Damn. So how we will move from version 10 in the future? IMHO, it's docker-compose meant for local development, not really a breaking change (we can note it in release).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We plan to upgrade but probably a better moment would be when we replace User email by User ID.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Btw looks really easy to do safe upgrade with few commands, for existing databases that want to keep data (even if its development setup).
@@ -18,7 +18,7 @@ volumes: | |||
|
|||
services: | |||
influxdb: | |||
image: influxdb:1.6.4-alpine | |||
image: influxdb:1.7-alpine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same there is a version 1.8.x-alpine.
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
* NOISSUE - Upgrade influxdb and postgres docker images Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Upgrade grafana version Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Upgrade influxdb to 1.8.3-alpine Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
Signed-off-by: Manuel Imperiale manuel.imperiale@gmail.com