-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NOISSUE - Upgrade Mongo, Cassandra and Influx docker images #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
dborovcanin
previously approved these changes
Feb 4, 2021
mteodor
previously approved these changes
Feb 4, 2021
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
blokovi
previously approved these changes
Feb 4, 2021
drasko
requested changes
Feb 4, 2021
@@ -24,7 +24,7 @@ func TestMain(m *testing.M) { | |||
"INFLUXDB_USER_PASSWORD=test", | |||
"INFLUXDB_DB=test", | |||
} | |||
container, err := pool.Run("influxdb", "1.6.4-alpine", cfg) | |||
container, err := pool.Run("influxdb", "1.8.3", cfg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we abandoning alpine
? Goal is to keep all images as small as possible.
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
blokovi
previously approved these changes
Feb 5, 2021
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
blokovi
approved these changes
Feb 5, 2021
drasko
approved these changes
Feb 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fbugarski
pushed a commit
to fbugarski/mainflux
that referenced
this pull request
Mar 8, 2021
…1354) * NOISSUE - Upgrade Mongo, Cassandra and Influx docker images Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Use cassandra version 3.11.9 Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Add MF_INFLUXDB_HTTP_AUTH_ENABLED envar Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Use influxdb 1.8.4-alpine Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Use influxdb 1.8.4 Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Manuel Imperiale manuel.imperiale@gmail.com