NOISSUE - Fix environment configuration and documentation #1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>
fbugarski
pushed a commit
to fbugarski/mainflux
that referenced
this pull request
Mar 8, 2021
Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dusanb94 dusan.borovcanin@mainflux.com
What does this do?
This pull request fixes inconsistent env variables naming and corresponding documentation.
Which issue(s) does this PR fix/relate to?
There is no such issue.
List any changes that modify/break current functionality
SMTP Nofifier service is using
MF_SMTP_NOTIFIER_PORTinstead ofMF_SMTP_NOTIFIER_HTTP_PORTsince it exposes only HTTP API.Have you included tests for your changes?
No, because changes are in the
main.gofile.Did you document any new/modified functionality?
Yes.