Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Add IsChannelOwner grpc endpoint #1366

Merged
merged 5 commits into from
Feb 22, 2021
Merged

Conversation

darkodraskovic
Copy link
Contributor

Signed-off-by: Darko Draskovic darko.draskovic@gmail.com

Add grpc support to things service to check if a given channel belongs to a given user.

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>
@darkodraskovic darkodraskovic requested a review from a team as a code owner February 18, 2021 15:27
@darkodraskovic darkodraskovic marked this pull request as draft February 18, 2021 15:28
Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>
@darkodraskovic darkodraskovic changed the title NOISSUE - Add CanAccessChannelByOwner grpc endpoint NOISSUE - Add IsChannelOwner grpc endpoint Feb 19, 2021
@darkodraskovic darkodraskovic marked this pull request as ready for review February 19, 2021 11:34
mteodor
mteodor previously approved these changes Feb 19, 2021
things/service_test.go Outdated Show resolved Hide resolved
things/service_test.go Outdated Show resolved Hide resolved
Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>
Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>
Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>
Copy link
Contributor

@manuio manuio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit 7ba3fdb into absmach:master Feb 22, 2021
fbugarski pushed a commit to fbugarski/mainflux that referenced this pull request Mar 8, 2021
* Add CanAccessChannelByOwner grpc endpoint

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

* Rename grpc endpoint to IsChannelOwner

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

* Add tests for IsChannelOwner grpc

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

* Bump protoc version

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

* Make proto

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants