-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NOISSUE - Add IsChannelOwner grpc endpoint #1366
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>
Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>
darkodraskovic
changed the title
NOISSUE - Add CanAccessChannelByOwner grpc endpoint
NOISSUE - Add IsChannelOwner grpc endpoint
Feb 19, 2021
mteodor
previously approved these changes
Feb 19, 2021
manuio
suggested changes
Feb 19, 2021
Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>
Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>
darkodraskovic
force-pushed
the
grpc
branch
3 times, most recently
from
February 22, 2021 10:52
9a53995
to
17cef05
Compare
Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>
manuio
approved these changes
Feb 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mteodor
approved these changes
Feb 22, 2021
drasko
approved these changes
Feb 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fbugarski
pushed a commit
to fbugarski/mainflux
that referenced
this pull request
Mar 8, 2021
* Add CanAccessChannelByOwner grpc endpoint Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com> * Rename grpc endpoint to IsChannelOwner Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com> * Add tests for IsChannelOwner grpc Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com> * Bump protoc version Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com> * Make proto Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Darko Draskovic darko.draskovic@gmail.com
Add grpc support to things service to check if a given channel belongs to a given user.