NOISSUE - Fix certs and vault deployment, reorganize and remove unnecessary vars #1368

mteodor · 2021-02-22T16:22:21Z

What does this do?

Reorganize cert enviroment variables and correct scripts for initializing vault PKI

codecov-io · 2021-02-22T17:02:44Z

Codecov Report

Merging #1368 (70405e8) into master (7bcaa32) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1368   +/-   ##
=======================================
  Coverage   60.51%   60.51%           
=======================================
  Files         123      123           
  Lines        9416     9416           
=======================================
  Hits         5698     5698           
  Misses       3223     3223           
  Partials      495      495

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bcaa32...70405e8. Read the comment docs.

cmd/certs/main.go

.env

cmd/certs/main.go

.env

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

drasko · 2021-03-01T16:40:49Z

.env

-MF_VAULT_CA_LOC=BG
+MF_VAULT_CA_O='Mainflux Co.'
+MF_VAULT_CA_C=Serbia
+MF_VAULT_CA_L=BG


Use Belgrade here if you used Serbia and not SR above. Stay consistent.

drasko · 2021-03-01T16:41:35Z

.env

-MF_VAULT_CA_ORG='Mainflux Company'
-MF_VAULT_CA_COUNTRY=Serbia
-MF_VAULT_CA_LOC=BG
+MF_VAULT_CA_O='Mainflux Co.'


Maybe Mainflux Labs

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

manuio

LGTM

drasko

LGTM

…essary vars (absmach#1368) * remove owner id Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix certs, fix scripts, reorganize env vars Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * set pki path vars Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add certs mock Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * remove not wanted changes Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * update readme Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * correct rsa_bits to key_bits Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix tabulation Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * hardcode vault version Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add env desc Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * renam variables Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * use Mainflux Labs Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * replace BG with Belgrade Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

mteodor marked this pull request as ready for review February 23, 2021 15:54

mteodor requested a review from a team as a code owner February 23, 2021 15:54

mteodor force-pushed the certs branch from cb0ff8d to 8ba015d Compare February 23, 2021 15:55

manuio suggested changes Feb 23, 2021

View reviewed changes

cmd/certs/main.go Show resolved Hide resolved

cmd/certs/main.go Show resolved Hide resolved

mteodor marked this pull request as draft February 23, 2021 16:30

mteodor added work-in-progress and removed work-in-progress labels Feb 23, 2021

mteodor marked this pull request as ready for review February 23, 2021 18:07

drasko requested changes Feb 23, 2021

View reviewed changes

.env Show resolved Hide resolved

cmd/certs/main.go Show resolved Hide resolved

nmarcetic previously approved these changes Feb 25, 2021

View reviewed changes

mteodor dismissed nmarcetic’s stale review via 75eb16b February 25, 2021 13:49

mteodor force-pushed the certs branch from 0357668 to 75eb16b Compare February 25, 2021 13:49

nmarcetic previously approved these changes Feb 26, 2021

View reviewed changes

mteodor dismissed nmarcetic’s stale review via 570cbd5 February 26, 2021 16:38

mteodor force-pushed the certs branch from 75eb16b to 570cbd5 Compare February 26, 2021 16:38

drasko requested changes Feb 27, 2021

View reviewed changes

.env Show resolved Hide resolved

mteodor changed the title ~~NOISSUE - Refactor certs, sort out deployment for certs and vault~~ NOISSUE - Fix certs and vault depoloyment, reorganize and remove unnecessary vars Feb 27, 2021

mteodor force-pushed the certs branch from 570cbd5 to 1275f5e Compare March 1, 2021 09:02

mteodor changed the title ~~NOISSUE - Fix certs and vault depoloyment, reorganize and remove unnecessary vars~~ NOISSUE - Fix certs and vault deployment, reorganize and remove unnecessary vars Mar 1, 2021

mteodor added 10 commits March 1, 2021 15:24

remove owner id

909b783

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

fix certs, fix scripts, reorganize env vars

d1749db

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

set pki path vars

549d090

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

add certs mock

4589bb0

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

remove not wanted changes

0d10ef0

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

update readme

badadf9

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

correct rsa_bits to key_bits

cc29e9d

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

fix tabulation

8e4073a

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

hardcode vault version

5fef106

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

add env desc

a1c183e

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

renam variables

7033f0a

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

mteodor force-pushed the certs branch from f565e6c to 7033f0a Compare March 1, 2021 14:24

drasko requested changes Mar 1, 2021

View reviewed changes

mteodor added 2 commits March 1, 2021 17:44

use Mainflux Labs

3c46c21

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

replace BG with Belgrade

70405e8

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

manuio approved these changes Mar 2, 2021

View reviewed changes

drasko approved these changes Mar 2, 2021

View reviewed changes

drasko merged commit 6b1f4d5 into absmach:master Mar 2, 2021

manuio mentioned this pull request Mar 5, 2021

MF-1368 - Add internal http api package for query params reading #1384

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NOISSUE - Fix certs and vault deployment, reorganize and remove unnecessary vars #1368

NOISSUE - Fix certs and vault deployment, reorganize and remove unnecessary vars #1368

mteodor commented Feb 22, 2021 •

edited

Loading

codecov-io commented Feb 22, 2021 •

edited

Loading

drasko Mar 1, 2021

drasko Mar 1, 2021

manuio left a comment

drasko left a comment

NOISSUE - Fix certs and vault deployment, reorganize and remove unnecessary vars #1368

NOISSUE - Fix certs and vault deployment, reorganize and remove unnecessary vars #1368

Conversation

mteodor commented Feb 22, 2021 • edited Loading

What does this do?

codecov-io commented Feb 22, 2021 • edited Loading

Codecov Report

drasko Mar 1, 2021

Choose a reason for hiding this comment

drasko Mar 1, 2021

Choose a reason for hiding this comment

manuio left a comment

Choose a reason for hiding this comment

drasko left a comment

Choose a reason for hiding this comment

mteodor commented Feb 22, 2021 •

edited

Loading

codecov-io commented Feb 22, 2021 •

edited

Loading