Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant endpoints from manager #138

Merged
merged 6 commits into from
Jan 5, 2018
Merged

Remove redundant endpoints from manager #138

merged 6 commits into from
Jan 5, 2018

Conversation

mijicd
Copy link
Contributor

@mijicd mijicd commented Dec 29, 2017

resolves #137

Features:

  • removed unnecessary endpoint
  • updated the API spec & implementation
  • updated the client API
  • set version to match the milestone 1.0.0-rc.1

Signed-off-by: Dejan Mijic <dejan@mainflux.com>
Instead of returning boolean value whether or not the access is granted,
an identifier bound to the provided access key is returned.

Signed-off-by: Dejan Mijic <dejan@mainflux.com>
Signed-off-by: Dejan Mijic <dejan@mainflux.com>
Signed-off-by: Dejan Mijic <dejan@mainflux.com>
Signed-off-by: Dejan Mijic <dejan@mainflux.com>
Signed-off-by: Dejan Mijic <dejan@mainflux.com>
@mijicd mijicd added this to the 1.0.0-rc.1 milestone Dec 29, 2017
@mijicd mijicd self-assigned this Dec 29, 2017
@mijicd mijicd requested a review from drasko December 29, 2017 10:13
@mijicd mijicd requested a review from a team as a code owner December 29, 2017 10:13
@mijicd mijicd closed this Dec 29, 2017
@mijicd mijicd deleted the mainflux-137 branch December 29, 2017 10:14
@mijicd mijicd restored the mainflux-137 branch December 29, 2017 10:15
@mijicd mijicd reopened this Dec 29, 2017
@mijicd mijicd modified the milestone: 1.0.0-rc.1 Dec 29, 2017
@mijicd mijicd removed this from the 1.0.0-rc.1 milestone Dec 29, 2017
@drasko drasko merged commit 8036c74 into master Jan 5, 2018
@mijicd mijicd mentioned this pull request Jan 6, 2018
@mijicd mijicd deleted the mainflux-137 branch January 6, 2018 21:51
dborovcanin referenced this pull request in dborovcanin/mainflux-old-fork May 9, 2018
Identity retrieval client code has been updated based on the changes of
the manager service API introduced in pull request #138.

Signed-off-by: Dejan Mijic <dejan@mainflux.com>
manuio pushed a commit that referenced this pull request Oct 12, 2020
Remove redundant endpoints from manager
mteodor pushed a commit to mteodor/mainflux that referenced this pull request Jun 9, 2021
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
arvindh123 pushed a commit to arvindh123/magistrala that referenced this pull request Dec 17, 2023
- Updated the error assertion in the invitations_test.go file.
- Replaced the assert.ErrorIs() function with assert.True() and errors.Contains() to check if the expected error is contained in the actual error.

Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove redundant endpoints from manager
2 participants