Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NOISSUE - Add missing auth port in nginx enrypoint.sh #1380

Merged
merged 2 commits into from
Mar 4, 2021
Merged

NOISSUE - Add missing auth port in nginx enrypoint.sh #1380

merged 2 commits into from
Mar 4, 2021

Conversation

mteodor
Copy link
Contributor

@mteodor mteodor commented Mar 4, 2021

What does this do?

Fix nginx configuration on startup, add missing auth service port in entrypoint.sh

@mteodor
remove owner id
7e6d2a6 
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
@mteodor
fix auth http port
f92a253 
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
@mteodor mteodor requested a review from a team as a code owner March 4, 2021 14:35
manuio
manuio approved these changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@manuio manuio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #1380 (f92a253) into master (530f925) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1380      +/-   ##
==========================================
+ Coverage   67.51%   67.56%   +0.04%     
==========================================
  Files         121      121              
  Lines        8408     8408              
==========================================
+ Hits         5677     5681       +4     
+ Misses       2216     2213       -3     
+ Partials      515      514       -1
Impacted Files Coverage Δ
things/service.go 69.50% <0.00%> (+1.41%) ⬆️
pkg/messaging/nats/publisher.go 37.50% <0.00%> (+12.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 530f925...f92a253. Read the comment docs.

@manuio manuio merged commit 259950b into absmach:master Mar 4, 2021
@mteodor mteodor deleted the auth-http-port branch September 13, 2021 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmarcetic nmarcetic nmarcetic approved these changes

@manuio manuio manuio approved these changes

@dborovcanin dborovcanin dborovcanin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mteodor @codecov-io @nmarcetic @manuio @dborovcanin