Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MF-1390 - Fix docker-compose env_file #1391

Merged
merged 2 commits into from
Mar 23, 2021
Merged

MF-1390 - Fix docker-compose env_file #1391

merged 2 commits into from
Mar 23, 2021

Conversation

manuio
Copy link
Contributor

@manuio manuio commented Mar 22, 2021

Signed-off-by: Manuel Imperiale manuel.imperiale@gmail.com

Resolves #1390

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
@manuio manuio requested a review from a team as a code owner March 22, 2021 17:33
blokovi
blokovi previously approved these changes Mar 22, 2021
drasko
drasko previously approved these changes Mar 22, 2021
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko
Copy link
Contributor

drasko commented Mar 22, 2021

@manuio Semaphore is failing.

Also - which Docker version is mandatory now?

@manuio manuio dismissed stale reviews from drasko and blokovi via fda46cb March 22, 2021 23:43
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manuio manuio merged commit bcdc6d2 into master Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker-compose .env bug
3 participants