Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Fix security warnings for dependencies #1452

Merged
merged 2 commits into from
Aug 23, 2021

Conversation

dborovcanin
Copy link
Collaborator

Signed-off-by: dusanb94 dusan.borovcanin@mainflux.com

What does this do?

This pull request fixes security vulnerabilities detected by the Dependabot.

Which issue(s) does this PR fix/relate to?

There is no such issue.

List any changes that modify/break current functionality

There are no such changes. Vulnerable libs are replaced by compatible ones or by patched versions of the same.

Have you included tests for your changes?

Yes.

Did you document any new/modified functionality?

No.

Notes

N/A

@dborovcanin dborovcanin requested a review from a team as a code owner August 23, 2021 12:56
drasko
drasko previously approved these changes Aug 23, 2021
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmarcetic
nmarcetic previously approved these changes Aug 23, 2021
@nmarcetic
Copy link
Collaborator

@dusanb94 CI is failing. Didn't have a chance to checkout

Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>
@drasko
Copy link
Contributor

drasko commented Aug 23, 2021

I redeployed, to see if that was a hiccup...

This feature is introduced here: https://tip.golang.org/doc/go1.17#vendor.

Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1452 (7764b53) into master (e1a66b3) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1452      +/-   ##
==========================================
- Coverage   70.92%   70.90%   -0.03%     
==========================================
  Files         123      123              
  Lines        9564     9564              
==========================================
- Hits         6783     6781       -2     
- Misses       2254     2256       +2     
  Partials      527      527              
Impacted Files Coverage Δ
auth/jwt/tokenizer.go 91.11% <ø> (ø)
things/service.go 72.02% <0.00%> (-1.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1a66b3...7764b53. Read the comment docs.

@drasko drasko merged commit caa4bda into absmach:master Aug 23, 2021
@dborovcanin dborovcanin deleted the fix-dependencies branch August 23, 2021 13:39
buraksekili pushed a commit to buraksekili/mainflux that referenced this pull request Sep 14, 2021
* Fix security warnings for dependencies

Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>

* Omit `.mod` and `.sum` files in dependencies

This feature is introduced here: https://tip.golang.org/doc/go1.17#vendor.

Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
mteodor pushed a commit to mteodor/mainflux that referenced this pull request Sep 15, 2021
* Fix security warnings for dependencies

Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>

* Omit `.mod` and `.sum` files in dependencies

This feature is introduced here: https://tip.golang.org/doc/go1.17#vendor.

Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants