Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NOISSUE - Add SMPP notifier #1464

Merged
merged 6 commits into from
Oct 6, 2021
Merged

NOISSUE - Add SMPP notifier #1464

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
758e9c4
Add SMPP notifier
blokovi Sep 20, 2021
06e9a9b
fix readme
blokovi Sep 20, 2021
783dbb0
resolve conversations
blokovi Sep 20, 2021
3750e47
Remove debug log
blokovi Sep 24, 2021
9b31fb9
Rename transmiter and transformer fields in struct
blokovi Oct 6, 2021
092ea0a
fix typo
blokovi Oct 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions consumers/notifiers/smpp/notifier.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ import (
var _ notifiers.Notifier = (*notifier)(nil)

type notifier struct {
t *smpp.Transmitter
tr transformers.Transformer
transmiter *smpp.Transmitter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: transmitter

tranformer transformers.Transformer
sourceAddrTON uint8
sourceAddrNPI uint8
destAddrTON uint8
Expand All @@ -37,8 +37,8 @@ func New(cfg Config) notifiers.Notifier {
}
t.Bind()
ret := &notifier{
t: t,
tr: json.New(),
transmiter: t,
tranformer: json.New(),
sourceAddrTON: cfg.SourceAddrTON,
destAddrTON: cfg.DestAddrTON,
sourceAddrNPI: cfg.SourceAddrNPI,
Expand All @@ -59,7 +59,7 @@ func (n *notifier) Notify(from string, to []string, msg messaging.Message) error
Text: pdutext.Raw(msg.Payload),
Register: pdufield.NoDeliveryReceipt,
}
_, err := n.t.Submit(send)
_, err := n.transmiter.Submit(send)
if err != nil {
return err
}
Expand Down