NOISSUE - Add view and list serials endpoints in certs service #1483

manuio · 2021-10-26T08:07:19Z

Signed-off-by: Manuel Imperiale manuel.imperiale@gmail.com

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

codecov-commenter · 2021-10-26T09:51:02Z

Codecov Report

Merging #1483 (2b92826) into master (dd7d52e) will decrease coverage by 0.02%.
The diff coverage is 45.33%.

@@            Coverage Diff             @@
##           master    #1483      +/-   ##
==========================================
- Coverage   67.59%   67.56%   -0.03%     
==========================================
  Files         133      133              
  Lines       10933    10979      +46     
==========================================
+ Hits         7390     7418      +28     
- Misses       2938     2953      +15     
- Partials      605      608       +3

Impacted Files	Coverage Δ
certs/postgres/certs.go	`0.00% <0.00%> (ø)`
certs/service.go	`85.71% <77.27%> (-2.75%)`	⬇️
things/service.go	`66.07% <0.00%> (+0.71%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd7d52e...2b92826. Read the comment docs.

docker/addons/vault/vault-unseal.sh

mteodor · 2021-10-26T10:12:34Z

certs/api/endpoint.go

@@ -20,12 +20,14 @@ func issueCert(svc certs.Service) endpoint.Endpoint {
 		if err != nil {


thanks @manuio for tightening this service, this change is not related to the stuff you did but if you could change req.Valid to req.TTL as that would be more appropriate ( and days_valid to TTL in openapi doc)

I like this proposition.

Is this resolved?

I'm not sure but I think that this remark was previous to the renaming of days_valid into hours_valid. IMO it's better to use hours_valid, it's self documenting. ttl is a Vault therminology.

TTL is not a Vault terminology.

I agree that hours_valid, while a little clumsy, is more self-documenting. However, since we are using it as a string, we can include a time determinant such as "h", "m" or "s", so TTL is probably a better naming. Also, since we don't control the aforementioned time determinant, hours in the name is actually misleading.

Right. What I mean is that we are using TTL in the pki layer but we don't necessaraly have to follow this therminology for the HTTP API. However we are using KeyBytes and KeyType so maybe I can change it.

@drasko @dusanb94 ok, let me rename then

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

drasko

This PR looks OK to me, but I would let @dusanb94 review and approve before we merge.

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

…ertion Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

mteodor

LGTM

drasko · 2021-11-05T11:22:01Z

I think there should be a documentation added for this

dborovcanin

Please add tests for new service methods.

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

…ertion Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

manuio · 2021-12-21T12:01:12Z

@drasko @dusanb94 Can you review please?

api/certs.yml

dborovcanin · 2021-12-31T16:02:19Z

certs/api/endpoint.go

@@ -20,12 +20,14 @@ func issueCert(svc certs.Service) endpoint.Endpoint {
 		if err != nil {


Is this resolved?

dborovcanin · 2021-12-31T16:03:08Z

certs/mocks/certs.go

+		c.certsByThingID[cert.OwnerID] = map[string][]certs.Cert{
+			cert.ThingID: []certs.Cert{crt},
+		}
+	} else {


Please avoid using else.

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

drasko

LGTM

…ch#1483) * NOISSUE - Add view and list serials endpoints in certs service Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Fix vault-unseal.sh script Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Rename Cert field days_valid into hours_valid Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Fix provision service Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Use ownerID, rename daysValid -> hoursValid Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Add key_type to api Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Fix tabulation Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Add expiration date in view response Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Rename HoursValid -> Expiration and remove unecessary expiration convertion Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Add ListSerials tests and fix mocks Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Fix RetrieveByThing count Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Add ViewCert tests Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Add missing error check Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Simplify API Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Revert Makefile Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Fix typo Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * NOISSUE - Add view and list serials endpoints in certs service Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Fix vault-unseal.sh script Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Rename Cert field days_valid into hours_valid Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Fix provision service Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Use ownerID, rename daysValid -> hoursValid Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Add key_type to api Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Fix tabulation Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Add expiration date in view response Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Rename HoursValid -> Expiration and remove unecessary expiration convertion Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Add ListSerials tests and fix mocks Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Fix RetrieveByThing count Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Add ViewCert tests Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Add missing error check Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Simplify API Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Revert Makefile Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Rm if else Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Rename HoursValid -> TTL Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * revert typo Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * revert typo Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Rename hoursValid -> ttl Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> Signed-off-by: skovacevic <stefan.kovacevic@mainflux.io>

NOISSUE - Add view and list serials endpoints in certs service

6dfb409

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

manuio requested a review from a team as a code owner October 26, 2021 08:07

Fix vault-unseal.sh script

786f0a7

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

mteodor reviewed Oct 26, 2021

View reviewed changes

docker/addons/vault/vault-unseal.sh Show resolved Hide resolved

mteodor reviewed Oct 26, 2021

View reviewed changes

Rename Cert field days_valid into hours_valid

3f27f8a

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

mteodor previously approved these changes Oct 26, 2021

View reviewed changes

Fix provision service

164ad0c

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

manuio dismissed mteodor’s stale review via 164ad0c October 26, 2021 16:53

manuio added 2 commits October 26, 2021 20:06

Use ownerID, rename daysValid -> hoursValid

859837a

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

Add key_type to api

1c17842

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

drasko reviewed Oct 26, 2021

View reviewed changes

manuio added 4 commits October 27, 2021 09:20

Fix tabulation

fe87cfc

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

Add expiration date in view response

a5900e9

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

Rename HoursValid -> Expiration and remove unecessary expiration conv…

88c7bda

…ertion Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

Merge branch 'master' of http://github.com/mainflux/mainflux into certs

b97a7db

mteodor approved these changes Oct 28, 2021

View reviewed changes

mteodor approved these changes Oct 29, 2021

View reviewed changes

mteodor previously approved these changes Nov 4, 2021

View reviewed changes

dborovcanin requested changes Nov 8, 2021

View reviewed changes

Add ListSerials tests and fix mocks

cb3ae7a

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

manuio dismissed mteodor’s stale review via cb3ae7a November 17, 2021 17:30

manuio added 2 commits November 17, 2021 11:35

Fix RetrieveByThing count

0cbe738

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

Add ViewCert tests

e804ba0

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

mteodor previously approved these changes Nov 18, 2021

View reviewed changes

Merge branch 'master' of http://github.com/mainflux/mainflux into certs

60be39e

blokovi previously approved these changes Nov 18, 2021

View reviewed changes

Add missing error check

1cf8ba0

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

manuio and others added 14 commits December 14, 2021 12:25

Use ownerID, rename daysValid -> hoursValid

d492125

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

Add key_type to api

8018ae3

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

Fix tabulation

c063642

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

Add expiration date in view response

1edb504

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

Rename HoursValid -> Expiration and remove unecessary expiration conv…

fdca4f4

…ertion Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

Add ListSerials tests and fix mocks

016c208

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

Fix RetrieveByThing count

e5f5107

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

Add ViewCert tests

29ea686

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

Add missing error check

4b34684

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

Simplify API

2fc8d0f

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

Revert Makefile

d246795

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

Fix merge

8b6bef5

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

Merge branch 'master' into certs

5ec2953

Merge branch 'master' into certs

245ebac

Merge branch 'master' into certs

231f110

dborovcanin requested changes Dec 31, 2021

View reviewed changes

manuio added 2 commits January 3, 2022 13:45

Rm if else

a0100d4

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

Merge branch 'certs' of http://github.com/manuio/mainflux into certs

95033bf

manuio dismissed stale reviews from blokovi and mteodor via 95033bf January 3, 2022 12:45

manuio added 4 commits January 3, 2022 14:21

Rename HoursValid -> TTL

61c203c

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

revert typo

df569df

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

revert typo

4c32c83

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

Rename hoursValid -> ttl

2b92826

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

dborovcanin approved these changes Jan 4, 2022

View reviewed changes

drasko approved these changes Jan 4, 2022

View reviewed changes

drasko merged commit aa014c2 into absmach:master Jan 4, 2022

manuio deleted the certs branch February 23, 2022 12:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NOISSUE - Add view and list serials endpoints in certs service #1483

NOISSUE - Add view and list serials endpoints in certs service #1483

manuio commented Oct 26, 2021

codecov-commenter commented Oct 26, 2021 •

edited

Loading

mteodor Oct 26, 2021

drasko Dec 5, 2021

dborovcanin Dec 31, 2021

manuio Jan 3, 2022

drasko Jan 3, 2022

dborovcanin Jan 3, 2022

manuio Jan 3, 2022

manuio Jan 3, 2022 •

edited

Loading

drasko left a comment

mteodor left a comment

drasko commented Nov 5, 2021

dborovcanin left a comment

manuio commented Dec 21, 2021

dborovcanin Dec 31, 2021

dborovcanin Dec 31, 2021

drasko left a comment

		@@ -20,12 +20,14 @@ func issueCert(svc certs.Service) endpoint.Endpoint {
		if err != nil {

NOISSUE - Add view and list serials endpoints in certs service #1483

NOISSUE - Add view and list serials endpoints in certs service #1483

Conversation

manuio commented Oct 26, 2021

codecov-commenter commented Oct 26, 2021 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

manuio Jan 3, 2022 • edited Loading

Choose a reason for hiding this comment

drasko left a comment

Choose a reason for hiding this comment

mteodor left a comment

Choose a reason for hiding this comment

drasko commented Nov 5, 2021

dborovcanin left a comment

Choose a reason for hiding this comment

manuio commented Dec 21, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

drasko left a comment

Choose a reason for hiding this comment

codecov-commenter commented Oct 26, 2021 •

edited

Loading

manuio Jan 3, 2022 •

edited

Loading