Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Fix assigning invalid group policy #1487

Merged
merged 1 commit into from
Oct 28, 2021

Conversation

buraksekili
Copy link
Contributor

Signed-off-by: Burak Sekili buraksekili@gmail.com

Pull request title should be MF-XXX - description or NOISSUE - description where XXX is ID of issue that this PR relate to.
Please review the CONTRIBUTING.md file for detailed contributing guidelines.

What does this do?

This PR updates memberRelation with accessRelation while assigning new members

Which issue(s) does this PR fix/relate to?

Put here Resolves #XXX to auto-close the issue that your PR fixes (if such)

List any changes that modify/break current functionality

Have you included tests for your changes?

Did you document any new/modified functionality?

Notes

Signed-off-by: Burak Sekili <buraksekili@gmail.com>
@buraksekili buraksekili requested a review from a team as a code owner October 28, 2021 07:55
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #1487 (43df7ce) into master (27d4646) will decrease coverage by 0.01%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1487      +/-   ##
==========================================
- Coverage   68.82%   68.80%   -0.02%     
==========================================
  Files         132      132              
  Lines       10581    10581              
==========================================
- Hits         7282     7280       -2     
- Misses       2724     2726       +2     
  Partials      575      575              
Impacted Files Coverage Δ
auth/service.go 76.24% <60.00%> (ø)
things/service.go 73.59% <0.00%> (-0.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27d4646...43df7ce. Read the comment docs.

@dborovcanin dborovcanin merged commit 30912e5 into absmach:master Oct 28, 2021
@buraksekili buraksekili deleted the group-access branch November 2, 2021 08:18
fbugarski pushed a commit to fbugarski/mainflux that referenced this pull request Nov 17, 2021
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
mteodor pushed a commit to mteodor/mainflux that referenced this pull request Dec 23, 2021
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
bioinformatx pushed a commit to bioinformatx/mainflux that referenced this pull request Jan 28, 2022
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Signed-off-by: skovacevic <stefan.kovacevic@mainflux.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants