NOISSUE - Update self register environment variable name #1493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* NOISSUE - Update naming of env variable Signed-off-by: Burak Sekili <buraksekili@gmail.com> * Update env variable type to boolean Signed-off-by: Burak Sekili <buraksekili@gmail.com> * update environment variable name Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com> update comment of selfregister Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1493 +/- ##
==========================================
- Coverage 68.82% 68.80% -0.02%
==========================================
Files 132 132
Lines 10581 10581
==========================================
- Hits 7282 7280 -2
- Misses 2724 2726 +2
Partials 575 575
Continue to review full report at Codecov.
|
dborovcanin
approved these changes
Nov 3, 2021
fbugarski
pushed a commit
to fbugarski/mainflux
that referenced
this pull request
Nov 17, 2021
* NOISSUE - Update naming of env variable (absmach#1484) Signed-off-by: Burak Sekili <buraksekili@gmail.com>
mteodor
pushed a commit
to mteodor/mainflux
that referenced
this pull request
Dec 23, 2021
* NOISSUE - Update naming of env variable (absmach#1484) Signed-off-by: Burak Sekili <buraksekili@gmail.com>
bioinformatx
pushed a commit
to bioinformatx/mainflux
that referenced
this pull request
Jan 28, 2022
* NOISSUE - Update naming of env variable (absmach#1484) Signed-off-by: Burak Sekili <buraksekili@gmail.com> Signed-off-by: skovacevic <stefan.kovacevic@mainflux.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
This PR updates the name of the environment variable responsible for allowing user creation by everybody or not. The previous name of it was
MF_ONLY_ADMIN_CREATES_USER. Now, it is updated toMF_USERS_ALLOW_SELF_REGISTERwhich is a boolean variable. IfMF_USERS_ALLOW_SELF_REGISTERis true, everybody can create a new user. Otherwise, only the admin can create a new user. Also,MF_USERS_ALLOW_SELF_REGISTERistrueby default.Furthermore, this PR updates the default admin creation process. The previous version was not checking the existence of the policy if
MF_USERS_ALLOW_SELF_REGISTERis true. However, ifMF_USERS_ALLOW_SELF_REGISTERis true, the policy has to be created. Therefore, this PR adds checking the existence of that policy whenMF_USERS_ALLOW_SELF_REGISTERis true.Which issue(s) does this PR fix/relate to?
-List any changes that modify/break current functionality
Update the environment variable.
Have you included tests for your changes?
No
Did you document any new/modified functionality?
Notes