Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Fix standalone mode #1497

Merged
merged 2 commits into from
Nov 16, 2021
Merged

Conversation

dborovcanin
Copy link
Collaborator

What does this do?

This pull request fixes Things service standalone mode.

Which issue(s) does this PR fix/relate to?

There is no such issue.

List any changes that modify/break current functionality

There are no such changes.

Have you included tests for your changes?

No.

Did you document any new/modified functionality?

No. The service now works in standalone mode as documented.

Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>
@dborovcanin dborovcanin requested a review from a team as a code owner November 16, 2021 11:19
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #1497 (0a04cd4) into master (3042d6b) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1497      +/-   ##
==========================================
- Coverage   68.83%   68.78%   -0.06%     
==========================================
  Files         132      132              
  Lines       10621    10623       +2     
==========================================
- Hits         7311     7307       -4     
- Misses       2729     2735       +6     
  Partials      581      581              
Impacted Files Coverage Δ
things/standalone/standalone.go 42.85% <0.00%> (-18.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3042d6b...0a04cd4. Read the comment docs.

@drasko drasko merged commit 39133b0 into absmach:master Nov 16, 2021
fbugarski pushed a commit to fbugarski/mainflux that referenced this pull request Nov 17, 2021
Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>

Co-authored-by: Drasko DRASKOVIC <drasko.draskovic@gmail.com>
mteodor pushed a commit to mteodor/mainflux that referenced this pull request Dec 23, 2021
Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>

Co-authored-by: Drasko DRASKOVIC <drasko.draskovic@gmail.com>
bioinformatx pushed a commit to bioinformatx/mainflux that referenced this pull request Jan 28, 2022
Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>

Co-authored-by: Drasko DRASKOVIC <drasko.draskovic@gmail.com>
Signed-off-by: skovacevic <stefan.kovacevic@mainflux.io>
@dborovcanin dborovcanin deleted the fix-stadnalone branch June 13, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants