NOISSUE - Remove dead code #1503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mteodor
previously approved these changes
Nov 23, 2021
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
buraksekili
dismissed stale reviews from drasko, manuio, and mteodor
via
5efdca8
buraksekili
force-pushed
the
remove-dead-code
branch
from
488d14d
to
5efdca8
Compare
Codecov Report
@@ Coverage Diff @@
## master #1503 +/- ##
=======================================
Coverage 68.24% 68.24%
=======================================
Files 132 132
Lines 10747 10747
=======================================
Hits 7334 7334
Misses 2826 2826
Partials 587 587
Continue to review full report at Codecov.
|
dborovcanin
approved these changes
Nov 24, 2021
mteodor
pushed a commit
to mteodor/mainflux
that referenced
this pull request
Dec 23, 2021
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
bioinformatx
pushed a commit
to bioinformatx/mainflux
that referenced
this pull request
Jan 28, 2022
Signed-off-by: Burak Sekili <buraksekili@gmail.com> Signed-off-by: skovacevic <stefan.kovacevic@mainflux.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Burak Sekili buraksekili@gmail.com
What does this do?
This PR removes a dead (commented) code as described here: https://github.com/mainflux/mainflux/pull/1502#discussion_r753387842
Which issue(s) does this PR fix/relate to?
-List any changes that modify/break current functionality
-Have you included tests for your changes?
-Did you document any new/modified functionality?
-Notes