NOISSUE - Remove auth URL from SDK #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Filip Bugarski <filipbugarski@gmail.com>
Signed-off-by: Filip Bugarski <filipbugarski@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1511 +/- ##
==========================================
+ Coverage 68.14% 68.16% +0.01%
==========================================
Files 132 132
Lines 10781 10781
==========================================
+ Hits 7347 7349 +2
+ Misses 2839 2838 -1
+ Partials 595 594 -1
Continue to review full report at Codecov.
|
drasko
requested changes
Nov 30, 2021
Signed-off-by: Filip Bugarski <filipbugarski@gmail.com>
Signed-off-by: Filip Bugarski <filipbugarski@gmail.com>
drasko
requested changes
Dec 1, 2021
pkg/sdk/go/groups.go
Outdated
|
|
||
| type assignRequest struct { | ||
| Type string `json:"type,omitempty"` | ||
| Members []string `json:"members"` | ||
| } | ||
|
|
||
| type Member struct { |
There was a problem hiding this comment.
I am not sure, but I think these kind of hig-level struct types are defined elsewhere. Probably in the sdk.go.
Signed-off-by: Filip Bugarski <filipbugarski@gmail.com>
dborovcanin
approved these changes
Dec 2, 2021
mteodor
pushed a commit
to mteodor/mainflux
that referenced
this pull request
Dec 23, 2021
* Remove auth URL from SDK Signed-off-by: Filip Bugarski <filipbugarski@gmail.com> * Update CLi/main.go authURL to GroupsURL Signed-off-by: Filip Bugarski <filipbugarski@gmail.com> * Add authURL back Signed-off-by: Filip Bugarski <filipbugarski@gmail.com> * Refactor group structures Signed-off-by: Filip Bugarski <filipbugarski@gmail.com> * Add AuthURL back to cli/main.go Signed-off-by: Filip Bugarski <filipbugarski@gmail.com>
bioinformatx
pushed a commit
to bioinformatx/mainflux
that referenced
this pull request
Jan 28, 2022
* Remove auth URL from SDK Signed-off-by: Filip Bugarski <filipbugarski@gmail.com> * Update CLi/main.go authURL to GroupsURL Signed-off-by: Filip Bugarski <filipbugarski@gmail.com> * Add authURL back Signed-off-by: Filip Bugarski <filipbugarski@gmail.com> * Refactor group structures Signed-off-by: Filip Bugarski <filipbugarski@gmail.com> * Add AuthURL back to cli/main.go Signed-off-by: Filip Bugarski <filipbugarski@gmail.com> Signed-off-by: skovacevic <stefan.kovacevic@mainflux.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Filip Bugarski filipbugarski@gmail.com
What does this do?
Remove authURL, and add groupsURL
Which issue(s) does this PR fix/relate to?
Put here
Resolves #XXXto auto-close the issue that your PR fixes (if such)List any changes that modify/break current functionality
Have you included tests for your changes?
Not needed
Did you document any new/modified functionality?
No
Notes