Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MF-1243 - Invalid require module github.com/mainflux/senml v1.5.0 in go.mod #1519

Merged
merged 2 commits into from
Dec 6, 2021

Conversation

dborovcanin
Copy link
Collaborator

Signed-off-by: dusanb94 dusan.borovcanin@mainflux.com

What does this do?

Fix SenML lib dependency version.

Which issue(s) does this PR fix/relate to?

This pull request closes #1243.

List any changes that modify/break current functionality

There are no such changes.

Have you included tests for your changes?

No, since this is only a dependency version update.

Did you document any new/modified functionality?

N/A

Notes

N/A

@dborovcanin dborovcanin requested a review from a team as a code owner December 6, 2021 08:56
Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1519 (ace5079) into master (5112ef6) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1519      +/-   ##
==========================================
- Coverage   68.14%   68.12%   -0.02%     
==========================================
  Files         132      132              
  Lines       10781    10781              
==========================================
- Hits         7347     7345       -2     
- Misses       2839     2841       +2     
  Partials      595      595              
Impacted Files Coverage Δ
things/service.go 64.98% <0.00%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5112ef6...ace5079. Read the comment docs.

Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko
Copy link
Contributor

drasko commented Dec 6, 2021

@dusanb94 please update the branch, and I will merge

@drasko drasko merged commit db6fab9 into absmach:master Dec 6, 2021
mteodor pushed a commit to mteodor/mainflux that referenced this pull request Dec 23, 2021
Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>

Co-authored-by: Drasko DRASKOVIC <drasko.draskovic@gmail.com>
bioinformatx pushed a commit to bioinformatx/mainflux that referenced this pull request Jan 28, 2022
Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>

Co-authored-by: Drasko DRASKOVIC <drasko.draskovic@gmail.com>
Signed-off-by: skovacevic <stefan.kovacevic@mainflux.io>
@dborovcanin dborovcanin deleted the MF-1243 branch January 12, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid require module github.com/mainflux/senml v1.5.0 in go.mod
3 participants