Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MF-1614 - Invalid handling of auth errors in Things service #1615

Merged
merged 4 commits into from
Jun 17, 2022

Conversation

dborovcanin
Copy link
Collaborator

Signed-off-by: dusanb94 dusan.borovcanin@mainflux.com

What does this do?

This pull request fixes error handling in the Things service in case of errors received during authentication or authorization.

Which issue(s) does this PR fix/relate to?

This pull request fixes #1614.

List any changes that modify/break current functionality

There are changes in API that now match documentation.

Have you included tests for your changes?

Yes, tests are modified to match the service behavior.

Did you document any new/modified functionality?

Yes.

Notes

N/A

Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>
@dborovcanin dborovcanin requested a review from a team as a code owner June 14, 2022 10:26
@manuio
Copy link
Contributor

manuio commented Jun 14, 2022

@dusanb94 CI is failling hings/api/things/http/endpoint_test.go:56:2: unauthzRes is unused

Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>
manuio
manuio previously approved these changes Jun 14, 2022
Copy link
Contributor

@manuio manuio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>
Copy link
Contributor

@manuio manuio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit 2a5884f into absmach:master Jun 17, 2022
@dborovcanin dborovcanin deleted the MF-1614 branch June 17, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid handling of auth errors in Things service
3 participants