Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MF-1630 - Replace old subscriptions with a new one instead of throwing an error #1633

Merged
merged 34 commits into from
Aug 12, 2022
Merged

MF-1630 - Replace old subscriptions with a new one instead of throwing an error #1633

merged 34 commits into from
Aug 12, 2022

Commits on Jul 26, 2022

  1. updated pubsub.subscribe() to delete and renew already subscribed obj… 

    …ects

Signed-off-by: aryan <aryangodara03@gmail.com>
    @AryanGodara
    AryanGodara committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    a7da62c View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2022

  1. fixing sync.mutex error 

    Signed-off-by: aryan <aryangodara03@gmail.com>
    @AryanGodara
    AryanGodara committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    47e1026 View commit details
    Browse the repository at this point in the history

  2. made changes to pubsub_test.go to fix failing CI 

    Signed-off-by: aryan <aryangodara03@gmail.com>
    @AryanGodara
    AryanGodara committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    6d3aa7d View commit details
    Browse the repository at this point in the history

  3. made some changes to pubsub.go 

    Signed-off-by: aryan <aryangodara03@gmail.com>
    @AryanGodara
    AryanGodara committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    7bcca16 View commit details
    Browse the repository at this point in the history

  4. made some changes to pubsub.go added flag var 

    Signed-off-by: aryan <aryangodara03@gmail.com>
    @AryanGodara
    AryanGodara committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    6eb49e8 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2022

  1. little code cleanup 

    Signed-off-by: aryan <aryangodara03@gmail.com>
    @AryanGodara
    AryanGodara committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    5497d23 View commit details
    Browse the repository at this point in the history

  2. minor change, to make code more intuitive 

    Signed-off-by: aryan <aryangodara03@gmail.com>
    @AryanGodara
    AryanGodara committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    76c0183 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2022

  1. added comment, removed the ws_client file 

    Signed-off-by: aryan <aryangodara03@gmail.com>
    @AryanGodara
    AryanGodara committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    6219f1d View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2022

  1. removed ErrAlreadySubscribed 

    Signed-off-by: aryan <aryangodara03@gmail.com>
    @AryanGodara
    AryanGodara committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    5b332c7 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2022

  1. fixed some failing tests, will check again after semaphore result 

    Signed-off-by: aryan <aryangodara03@gmail.com>
    @AryanGodara
    AryanGodara committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    d22fc22 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2022

  1. made similar changes for MQTT and rabbitMQ 

    Signed-off-by: aryan <aryangodara03@gmail.com>
    @AryanGodara
    AryanGodara committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    e9de8c1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/AryanGodara/mainflux into… 

    … replace-subscription
    @AryanGodara
    AryanGodara committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    48875da View commit details
    Browse the repository at this point in the history

  3. removed extra comment 

    Signed-off-by: aryan <aryangodara03@gmail.com>
    @AryanGodara
    AryanGodara committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    8ff2828 View commit details
    Browse the repository at this point in the history

  4. removed extra comment 

    Signed-off-by: aryan <aryangodara03@gmail.com>
    @AryanGodara
    AryanGodara committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    a5e6434 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2022

  1. removed extra comment 

    Signed-off-by: aryan <aryangodara03@gmail.com>
    @AryanGodara
    AryanGodara committed Aug 6, 2022
    Configuration menu
    Copy the full SHA
    835922d View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2022

  1. to fix failing CI 

    Signed-off-by: aryan <aryangodara03@gmail.com>
    @AryanGodara
    AryanGodara committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    a976de7 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2022

  1. checking code after adding conditions 

    Signed-off-by: aryan <aryangodara03@gmail.com>
    @AryanGodara
    AryanGodara committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    d21b917 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2022

  1. Merge branch 'master' of https://github.com/AryanGodara/mainflux into… 

    … replace-subscription
    @AryanGodara
    AryanGodara committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    2513f8c View commit details
    Browse the repository at this point in the history

  2. added ps.mu.Lock(), and changed len(s) 

    Signed-off-by: aryan <aryangodara03@gmail.com>
    @AryanGodara
    AryanGodara committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    cdb8d5d View commit details
    Browse the repository at this point in the history

  3. added tests for failing unsubscribe 

    Signed-off-by: aryan <aryangodara03@gmail.com>
    @AryanGodara
    AryanGodara committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    a97cbd3 View commit details
    Browse the repository at this point in the history

  4. shifted defer lock 

    Signed-off-by: aryan <aryangodara03@gmail.com>
    @AryanGodara
    AryanGodara committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    b608f41 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' of https://github.com/AryanGodara/mainflux into… 

    … replace-subscription
    @AryanGodara
    AryanGodara committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    cf71814 View commit details
    Browse the repository at this point in the history

  6. fixed mqtt/pubsub 

    Signed-off-by: aryan <aryangodara03@gmail.com>
    @AryanGodara
    AryanGodara committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    7d53a14 View commit details
    Browse the repository at this point in the history

  7. fix mqtt/pubsub typo 

    Signed-off-by: aryan <aryangodara03@gmail.com>
    @AryanGodara
    AryanGodara committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    6fecbe3 View commit details
    Browse the repository at this point in the history

  8. add comment to improve readability 

    Signed-off-by: aryan <aryangodara03@gmail.com>
    @AryanGodara
    AryanGodara committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    58031ad View commit details
    Browse the repository at this point in the history

  9. add comment to better improve readability 

    Signed-off-by: aryan <aryangodara03@gmail.com>
    @AryanGodara
    AryanGodara committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    351b3bc View commit details
    Browse the repository at this point in the history

  10. add comments for docs 

    Signed-off-by: aryan <aryangodara03@gmail.com>
    @AryanGodara
    AryanGodara committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    20ca42a View commit details
    Browse the repository at this point in the history

  11. improve doc comment 

    Signed-off-by: aryan <aryangodara03@gmail.com>
    @AryanGodara
    AryanGodara committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    c13426b View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2022

  1. Merge branch 'master' of https://github.com/AryanGodara/mainflux into… 

    … replace-subscription
    @AryanGodara
    AryanGodara committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    9a63589 View commit details
    Browse the repository at this point in the history

  2. change to mqtt/pubsub 

    Signed-off-by: aryan <aryangodara03@gmail.com>
    @AryanGodara
    AryanGodara committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    c72e5fb View commit details
    Browse the repository at this point in the history

  3. remove unnecessary mutex lock 

    Signed-off-by: aryan <aryangodara03@gmail.com>
    @AryanGodara
    AryanGodara committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    6076dbd View commit details
    Browse the repository at this point in the history

  4. change to pubsub 

    Signed-off-by: aryan <aryangodara03@gmail.com>
    @AryanGodara
    AryanGodara committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    c3e8065 View commit details
    Browse the repository at this point in the history

  5. add comments to improve readability 

    Signed-off-by: aryan <aryangodara03@gmail.com>
    @AryanGodara
    AryanGodara committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    d484937 View commit details
    Browse the repository at this point in the history

  6. fix typo in comment 

    Signed-off-by: aryan <aryangodara03@gmail.com>
    @AryanGodara
    AryanGodara committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    ff6c6ba View commit details
    Browse the repository at this point in the history