NOISSUE - Update pubsub tests for rabbitmq #1656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: aryan <aryangodara03@gmail.com>
Signed-off-by: aryan <aryangodara03@gmail.com>
Signed-off-by: aryan <aryangodara03@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1656 +/- ##
==========================================
- Coverage 70.29% 70.28% -0.02%
==========================================
Files 148 148
Lines 11508 11509 +1
==========================================
- Hits 8090 8089 -1
- Misses 2754 2755 +1
- Partials 664 665 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: aryan <aryangodara03@gmail.com>
AryanGodara
force-pushed
the
update-pubsub-tests
branch
2 times, most recently
from
84473e7
to
840898c
Compare
Signed-off-by: aryan <aryangodara03@gmail.com>
Signed-off-by: aryan <aryangodara03@gmail.com>
AryanGodara
force-pushed
the
update-pubsub-tests
branch
from
8eff0ad
to
61e22c2
Compare
Signed-off-by: aryan <aryangodara03@gmail.com>
Signed-off-by: aryan <aryangodara03@gmail.com>
Signed-off-by: aryan <aryangodara03@gmail.com>
Signed-off-by: aryan <aryangodara03@gmail.com>
Signed-off-by: aryan <aryangodara03@gmail.com>
Signed-off-by: aryan <aryangodara03@gmail.com>
Signed-off-by: aryan <aryangodara03@gmail.com>
drasko
requested changes
Oct 21, 2022
AryanGodara
force-pushed
the
update-pubsub-tests
branch
from
28ef82e
to
ca3b704
Compare
Signed-off-by: aryan <aryangodara03@gmail.com>
AryanGodara
force-pushed
the
update-pubsub-tests
branch
from
ca3b704
to
d2bda83
Compare
… update-pubsub-tests
Signed-off-by: aryan <aryangodara03@gmail.com>
Signed-off-by: aryan <aryangodara03@gmail.com>
drasko
requested changes
Dec 15, 2022
Signed-off-by: aryan <aryangodara03@gmail.com>
AryanGodara
force-pushed
the
update-pubsub-tests
branch
from
8e59b17
to
b9f4fa3
Compare
… update-pubsub-tests
dborovcanin
requested changes
Dec 15, 2022
Signed-off-by: aryan <aryangodara03@gmail.com>
AryanGodara
force-pushed
the
update-pubsub-tests
branch
from
88a1ebf
to
8ad6a36
Compare
Signed-off-by: aryan <aryangodara03@gmail.com>
Signed-off-by: aryan <aryangodara03@gmail.com>
AryanGodara
changed the title
Signed-off-by: aryan <aryangodara03@gmail.com>
… update-pubsub-tests
Signed-off-by: aryan <aryangodara03@gmail.com>
AryanGodara
force-pushed
the
update-pubsub-tests
branch
from
31a20d0
to
c3a3f48
Compare
dborovcanin
approved these changes
Dec 30, 2022
rodneyosodo
pushed a commit
to rodneyosodo/magistrala
that referenced
this pull request
Feb 2, 2023
* testPubSub failing on channel Signed-off-by: aryan <aryangodara03@gmail.com> * testPubSub failing, rest passing Signed-off-by: aryan <aryangodara03@gmail.com> * all tests passing Signed-off-by: aryan <aryangodara03@gmail.com> * removed unnecessary lines Signed-off-by: aryan <aryangodara03@gmail.com> * rename subunsub to unsubscribe Signed-off-by: aryan <aryangodara03@gmail.com> * nats tests working, rabbitmq left Signed-off-by: aryan <aryangodara03@gmail.com> * fix TestPublisher Signed-off-by: aryan <aryangodara03@gmail.com> * changed clientID of pubsub Signed-off-by: aryan <aryangodara03@gmail.com> * testSubscribe failing, rest all passing Signed-off-by: aryan <aryangodara03@gmail.com> * testPubsub failing Signed-off-by: aryan <aryangodara03@gmail.com> * TestSubscribe(s) failing, rest tests passing. Signed-off-by: aryan <aryangodara03@gmail.com> * For Rabbitmq, all tests are passing. Signed-off-by: aryan <aryangodara03@gmail.com> * For Nats, All tests passing, but unreliable Signed-off-by: aryan <aryangodara03@gmail.com> * Fix typos and improve variable names. Signed-off-by: aryan <aryangodara03@gmail.com> * nats tests passing, rabbitmq half tests passing. Signed-off-by: aryan <aryangodara03@gmail.com> * all tests working. Signed-off-by: aryan <aryangodara03@gmail.com> * removed commented out, dead code. Signed-off-by: aryan <aryangodara03@gmail.com> * fix errors, queuesubscribe tests for nats. Signed-off-by: aryan <aryangodara03@gmail.com> * updated broker.Connect to opts.Connect for nats. Signed-off-by: aryan <aryangodara03@gmail.com> * experimental soluton Signed-off-by: aryan <aryangodara03@gmail.com> * Revert nats back to original status. Signed-off-by: aryan <aryangodara03@gmail.com> * Remove unnecessary commit Signed-off-by: aryan <aryangodara03@gmail.com> Signed-off-by: aryan <aryangodara03@gmail.com> Signed-off-by: rodneyosodo <blackd0t@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: aryan aryangodara03@gmail.com
What does this do?
Adds tests for the nats implementation of pkg/messaging. nats part is left out for now.
Which issue(s) does this PR fix/relate to?
N/A
List any changes that modify/break current functionality
Nil
Have you included tests for your changes?
Yes
Did you document any new/modified functionality?
N/A
Notes
N/A