MF-1681 - Failed to reconnect to NATS #1686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>
drasko
requested changes
Dec 21, 2022
pkg/messaging/nats/publisher.go
Outdated
| @@ -22,7 +22,7 @@ type publisher struct { | |||
|
|
|||
| // NewPublisher returns NATS message Publisher. | |||
| func NewPublisher(url string) (messaging.Publisher, error) { | |||
| conn, err := broker.Connect(url) | |||
| conn, err := broker.Connect(url, broker.MaxReconnects(-1)) | |||
There was a problem hiding this comment.
I would define this constant somewhere and give it a self-documenting name, like tryForever, or you can leave a comment what this -1 means (for someone reading the code for the first time)
Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>
rodneyosodo
pushed a commit
to rodneyosodo/magistrala
that referenced
this pull request
Feb 2, 2023
* Make NATS reconnect never give up Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> * Extract maxReconnects to a constant Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> Signed-off-by: rodneyosodo <blackd0t@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dusanb94 dusan.borovcanin@mainflux.com
What does this do?
Currently, connection to NATS defaults to a max of 60 reconnect attempts before giving up and leaving the connection permanently closed. This approach causes the problem in case the service has been disconnected from the NATS server for whatever reasons.
This pull request makes a connection to NATS to never give up on trying to reconnect.
Which issue(s) does this PR fix/relate to?
This pull request fixes #1681.
List any changes that modify/break current functionality
There are no such changes.
Have you included tests for your changes?
N/A
Did you document any new/modified functionality?
N/A
Notes
N/A