Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Trim trailing and leading whitespaces in email at login & register #1687

Merged
merged 5 commits into from
Dec 21, 2022

Conversation

arvindh123
Copy link
Contributor

@arvindh123 arvindh123 commented Dec 21, 2022

Signed-off-by: Arvindh arvindh91@gmail.com

What does this do?

Trim trailing and leading whitespace in an email at login & register.

Which issue(s) does this PR fix/relate to?

There is no such issue.

List any changes that modify/break current functionality

N/A

Have you included tests for your changes?

N/A

Did you document any new/modified functionality?

N/A

Notes

N/A

Signed-off-by: Arvindh <arvindh91@gmail.com>
@arvindh123 arvindh123 changed the title NOISSUE: trim email in users at login & register NOISSUE: trim trailing and leading whitespace in email at login & register Dec 21, 2022
@dborovcanin dborovcanin changed the title NOISSUE: trim trailing and leading whitespace in email at login & register NOISSUE - Trim trailing and leading whitespaces in email at login & register Dec 21, 2022
@dborovcanin dborovcanin marked this pull request as ready for review December 21, 2022 15:00
@dborovcanin dborovcanin requested a review from a team as a code owner December 21, 2022 15:00
@codecov-commenter
Copy link

Codecov Report

Merging #1687 (ce16a7e) into master (f438d24) will increase coverage by 0.00%.
The diff coverage is 75.00%.

@@           Coverage Diff           @@
##           master    #1687   +/-   ##
=======================================
  Coverage   70.26%   70.26%           
=======================================
  Files         148      148           
  Lines       11501    11509    +8     
=======================================
+ Hits         8081     8087    +6     
- Misses       2756     2758    +2     
  Partials      664      664           
Impacted Files Coverage Δ
users/users.go 75.60% <0.00%> (-3.88%) ⬇️
users/api/endpoint.go 46.30% <100.00%> (+0.73%) ⬆️
users/api/requests.go 42.42% <100.00%> (+3.71%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit 57e3c25 into absmach:master Dec 21, 2022
rodneyosodo pushed a commit to rodneyosodo/magistrala that referenced this pull request Feb 2, 2023
…egister (absmach#1687)

* add: trim email in users at login & register

Signed-off-by: Arvindh <arvindh91@gmail.com>

* add: trim email in users at login & register

Signed-off-by: Arvindh <arvindh91@gmail.com>

* add: trim email in users at login & register

Signed-off-by: Arvindh <arvindh91@gmail.com>

Signed-off-by: Arvindh <arvindh91@gmail.com>
Co-authored-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>
Signed-off-by: rodneyosodo <blackd0t@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants